Merge branch '4.0'

* 4.0: (28 commits)
  [DI] Add tests for EnvVarProcessor
  typo
  [Bridge\PhpUnit] Fix #26430 Cannot autoload listeners
  Make sure we always render errors. Eventhough labels are disabled
  Make sure form errors is valid HTML
  [HttpKernel] Allow generators in registerBundle
  [TwigBundle] document TwigRenderer BC break in UPGRADE-3.4
  Extra line to bootstrap 3 horizontal layout
  [Serializer] Remove const override
  Update Client.php
  [PhpUnitBridge] Ability to use different composer.json file
  [DomCrawler] FormField: remove an useless return statement
  [Config] ReflectionClassResource check abstract ServiceSubscriberInterface and EventSubscriberInterface
  Display the Welcome Page when there is no homepage defined
  [DI] Remove dead dumper check
  Make KernelInterface docblock more fit for bundle-less environment
  fix regression when extending the Container class without a constructor
  fix the updating of timestamp in the MemcachedSessionHandler
  [SecurityBundle] Make extra character non mandatory in regex
  [Config] Add characters to the regex
  ...

Author: nicolas-grekas

Matcher/Dumper/PhpMatcherDumper.php

@@ -193,11 +193,10 @@ private function compileRoutes(RouteCollection $routes, bool $matchHost): string
             }
         }
 
-        if ('' === $code) {
-            $code .= "        if ('/' === \$pathinfo) {\n";
-            $code .= "            throw new Symfony\Component\Routing\Exception\NoConfigurationException();\n";
-            $code .= "        }\n";
-        }
+        // used to display the Welcome Page in apps that don't define a homepage
+        $code .= "        if ('/' === \$pathinfo) {\n";
+        $code .= "            throw new Symfony\Component\Routing\Exception\NoConfigurationException();\n";
+        $code .= "        }\n";
 
         return $code;
     }

Matcher/UrlMatcher.php

@@ -88,7 +88,7 @@ public function match($pathinfo)
             return $ret;
         }
 
-        if (0 === count($this->routes) && '/' === $pathinfo) {
+        if ('/' === $pathinfo) {
             throw new NoConfigurationException();
         }
 

Tests/Fixtures/dumper/url_matcher1.php

@@ -238,6 +238,9 @@ public function match($rawPathinfo)
                 $offset += strlen($m);
             }
         }
+        if ('/' === $pathinfo) {
+            throw new Symfony\Component\Routing\Exception\NoConfigurationException();
+        }
 
         throw $allow ? new MethodNotAllowedException(array_keys($allow)) : new ResourceNotFoundException();
     }

Tests/Fixtures/dumper/url_matcher10.php

@@ -2821,6 +2821,9 @@ public function match($rawPathinfo)
                 $offset += strlen($m);
             }
         }
+        if ('/' === $pathinfo) {
+            throw new Symfony\Component\Routing\Exception\NoConfigurationException();
+        }
 
         throw $allow ? new MethodNotAllowedException(array_keys($allow)) : new ResourceNotFoundException();
     }

Tests/Fixtures/dumper/url_matcher11.php

@@ -146,6 +146,9 @@ private function doMatch(string $rawPathinfo, array &$allow = array(), array &$a
                 $offset += strlen($m);
             }
         }
+        if ('/' === $pathinfo) {
+            throw new Symfony\Component\Routing\Exception\NoConfigurationException();
+        }
 
         return null;
     }

Tests/Fixtures/dumper/url_matcher12.php

@@ -91,6 +91,9 @@ public function match($rawPathinfo)
                 $offset += strlen($m);
             }
         }
+        if ('/' === $pathinfo) {
+            throw new Symfony\Component\Routing\Exception\NoConfigurationException();
+        }
 
         throw $allow ? new MethodNotAllowedException(array_keys($allow)) : new ResourceNotFoundException();
     }

Tests/Fixtures/dumper/url_matcher13.php

@@ -60,6 +60,9 @@ public function match($rawPathinfo)
                 $offset += strlen($m);
             }
         }
+        if ('/' === $pathinfo) {
+            throw new Symfony\Component\Routing\Exception\NoConfigurationException();
+        }
 
         throw $allow ? new MethodNotAllowedException(array_keys($allow)) : new ResourceNotFoundException();
     }

Tests/Fixtures/dumper/url_matcher2.php

@@ -275,6 +275,9 @@ private function doMatch(string $rawPathinfo, array &$allow = array(), array &$a
                 $offset += strlen($m);
             }
         }
+        if ('/' === $pathinfo) {
+            throw new Symfony\Component\Routing\Exception\NoConfigurationException();
+        }
 
         return null;
     }

Tests/Fixtures/dumper/url_matcher3.php

@@ -103,6 +103,9 @@ public function match($rawPathinfo)
                 $offset += strlen($m);
             }
         }
+        if ('/' === $pathinfo) {
+            throw new Symfony\Component\Routing\Exception\NoConfigurationException();
+        }
 
         throw $allow ? new MethodNotAllowedException(array_keys($allow)) : new ResourceNotFoundException();
     }

Tests/Fixtures/dumper/url_matcher4.php

@@ -75,6 +75,10 @@ public function match($rawPathinfo)
                 return $ret;
         }
 
+        if ('/' === $pathinfo) {
+            throw new Symfony\Component\Routing\Exception\NoConfigurationException();
+        }
+
         throw $allow ? new MethodNotAllowedException(array_keys($allow)) : new ResourceNotFoundException();
     }
 }