replace assertEmpty() with stricter assertions

xabbuh · xabbuh · commit 90d6605f1a34 · 2025-03-05T11:15:41.000+01:00
diff --git a/Tests/OptionsResolverTest.php b/Tests/OptionsResolverTest.php
@@ -1585,7 +1585,7 @@ public function testNormalizerNotCalledForUnsetOptions()
             Assert::fail('Should not be called.');
         });
 
-        $this->assertEmpty($this->resolver->resolve());
+        $this->assertSame([], $this->resolver->resolve());
     }
 
     public function testAddNormalizerReturnsThis()
@@ -1768,7 +1768,7 @@ public function testClearRemovesAllOptions()
 
         $this->resolver->clear();
 
-        $this->assertEmpty($this->resolver->resolve());
+        $this->assertSame([], $this->resolver->resolve());
     }
 
     public function testClearLazyOption()
@@ -1829,7 +1829,7 @@ public function testClearOptionAndNormalizer()
         $this->resolver->setNormalizer('foo2', fn (Options $options) => '');
 
         $this->resolver->clear();
-        $this->assertEmpty($this->resolver->resolve());
+        $this->assertSame([], $this->resolver->resolve());
     }
 
     public function testArrayAccess()

Original file line number	Diff line number	Diff line change
`@@ -1585,7 +1585,7 @@ public function testNormalizerNotCalledForUnsetOptions()`
`1585`	`1585`	`Assert::fail('Should not be called.');`
`1586`	`1586`	`});`
`1587`	`1587`
`1588`		`- $this->assertEmpty($this->resolver->resolve());`
	`1588`	`+ $this->assertSame([], $this->resolver->resolve());`
`1589`	`1589`	`}`
`1590`	`1590`
`1591`	`1591`	`public function testAddNormalizerReturnsThis()`
`@@ -1768,7 +1768,7 @@ public function testClearRemovesAllOptions()`
`1768`	`1768`
`1769`	`1769`	`$this->resolver->clear();`
`1770`	`1770`
`1771`		`- $this->assertEmpty($this->resolver->resolve());`
	`1771`	`+ $this->assertSame([], $this->resolver->resolve());`
`1772`	`1772`	`}`
`1773`	`1773`
`1774`	`1774`	`public function testClearLazyOption()`
`@@ -1829,7 +1829,7 @@ public function testClearOptionAndNormalizer()`
`1829`	`1829`	`$this->resolver->setNormalizer('foo2', fn (Options $options) => '');`
`1830`	`1830`
`1831`	`1831`	`$this->resolver->clear();`
`1832`		`- $this->assertEmpty($this->resolver->resolve());`
	`1832`	`+ $this->assertSame([], $this->resolver->resolve());`
`1833`	`1833`	`}`
`1834`	`1834`
`1835`	`1835`	`public function testArrayAccess()`