Removed legacy code and cleanup

yceruto · fabpot · commit 72aa8ca040ed · 2019-06-25T20:29:20.000+02:00
diff --git a/OptionsResolver.php b/OptionsResolver.php
@@ -846,8 +846,6 @@ public function offsetGet($option, bool $triggerDeprecation = true)
             throw new AccessException('Array access is only supported within closures of lazy options and normalizers.');
         }
 
-        $triggerDeprecation = 1 === \func_num_args() || func_get_arg(1);
-
         // Shortcut for resolved options
         if (isset($this->resolved[$option]) || \array_key_exists($option, $this->resolved)) {
             if ($triggerDeprecation && isset($this->deprecated[$option]) && (isset($this->given[$option]) || $this->calling) && \is_string($this->deprecated[$option])) {

Original file line number	Diff line number	Diff line change
`@@ -846,8 +846,6 @@ public function offsetGet($option, bool $triggerDeprecation = true)`
`846`	`846`	`throw new AccessException('Array access is only supported within closures of lazy options and normalizers.');`
`847`	`847`	`}`
`848`	`848`
`849`		`- $triggerDeprecation = 1 === \func_num_args() \|\| func_get_arg(1);`
`850`		`-`
`851`	`849`	`// Shortcut for resolved options`
`852`	`850`	`if (isset($this->resolved[$option]) \|\| \array_key_exists($option, $this->resolved)) {`
`853`	`851`	`if ($triggerDeprecation && isset($this->deprecated[$option]) && (isset($this->given[$option]) \|\| $this->calling) && \is_string($this->deprecated[$option])) {`