[OptionsResolver] Allow Union/Intersection Types in Resolved Closures

Author: zanbaldwin

OptionsResolver.php

@@ -232,7 +232,7 @@ public function setDefault(string $option, mixed $value): static
                 return $this;
             }
 
-            if (isset($params[0]) && null !== ($type = $params[0]->getType()) && self::class === $type->getName() && (!isset($params[1]) || (($type = $params[1]->getType()) instanceof \ReflectionNamedType && Options::class === $type->getName()))) {
+            if (isset($params[0]) && ($type = $params[0]->getType()) instanceof \ReflectionNamedType && self::class === $type->getName() && (!isset($params[1]) || (($type = $params[1]->getType()) instanceof \ReflectionNamedType && Options::class === $type->getName()))) {
                 // Store closure for later evaluation
                 $this->nested[$option][] = $value;
                 $this->defaults[$option] = [];

Tests/OptionsResolverTest.php

@@ -159,6 +159,28 @@ public function testClosureWithoutParametersNotInvoked()
         $this->assertSame(['foo' => $closure], $this->resolver->resolve());
     }
 
+    public function testClosureWithUnionTypesNotInvoked()
+    {
+        $closure = function (int|string|null $value) {
+            Assert::fail('Should not be called');
+        };
+
+        $this->resolver->setDefault('foo', $closure);
+
+        $this->assertSame(['foo' => $closure], $this->resolver->resolve());
+    }
+
+    public function testClosureWithIntersectionTypesNotInvoked()
+    {
+        $closure = function (\Stringable&\JsonSerializable $value) {
+            Assert::fail('Should not be called');
+        };
+
+        $this->resolver->setDefault('foo', $closure);
+
+        $this->assertSame(['foo' => $closure], $this->resolver->resolve());
+    }
+
     public function testAccessPreviousDefaultValue()
     {
         // defined by superclass