Merge branch '4.1'

* 4.1:
  Fix Clidumper tests
  Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
  Apply fixers
  Disable the native_constant_invocation fixer until it can be scoped
  Update the list of excluded files for the CS fixer

Author: nicolas-grekas

Debug/OptionsResolverIntrospector.php

@@ -47,7 +47,7 @@ public function __construct(OptionsResolver $optionsResolver)
      */
     public function getDefault(string $option)
     {
-        return call_user_func($this->get, 'defaults', $option, sprintf('No default value was set for the "%s" option.', $option));
+        return \call_user_func($this->get, 'defaults', $option, sprintf('No default value was set for the "%s" option.', $option));
     }
 
     /**
@@ -57,7 +57,7 @@ public function getDefault(string $option)
      */
     public function getLazyClosures(string $option): array
     {
-        return call_user_func($this->get, 'lazy', $option, sprintf('No lazy closures were set for the "%s" option.', $option));
+        return \call_user_func($this->get, 'lazy', $option, sprintf('No lazy closures were set for the "%s" option.', $option));
     }
 
     /**
@@ -67,7 +67,7 @@ public function getLazyClosures(string $option): array
      */
     public function getAllowedTypes(string $option): array
     {
-        return call_user_func($this->get, 'allowedTypes', $option, sprintf('No allowed types were set for the "%s" option.', $option));
+        return \call_user_func($this->get, 'allowedTypes', $option, sprintf('No allowed types were set for the "%s" option.', $option));
     }
 
     /**
@@ -77,14 +77,14 @@ public function getAllowedTypes(string $option): array
      */
     public function getAllowedValues(string $option): array
     {
-        return call_user_func($this->get, 'allowedValues', $option, sprintf('No allowed values were set for the "%s" option.', $option));
+        return \call_user_func($this->get, 'allowedValues', $option, sprintf('No allowed values were set for the "%s" option.', $option));
     }
 
     /**
      * @throws NoConfigurationException on no configured normalizer
      */
     public function getNormalizer(string $option): \Closure
     {
-        return call_user_func($this->get, 'normalizers', $option, sprintf('No normalizer was set for the "%s" option.', $option));
+        return \call_user_func($this->get, 'normalizers', $option, sprintf('No normalizer was set for the "%s" option.', $option));
     }
 }

OptionsResolver.php

@@ -535,7 +535,7 @@ public function addAllowedValues($option, $allowedValues)
             ));
         }
 
-        if (!is_array($allowedValues)) {
+        if (!\is_array($allowedValues)) {
             $allowedValues = array($allowedValues);
         }
 
@@ -718,12 +718,12 @@ public function resolve(array $options = array())
         // Make sure that no unknown options are passed
         $diff = array_diff_key($options, $clone->defined);
 
-        if (count($diff) > 0) {
+        if (\count($diff) > 0) {
             ksort($clone->defined);
             ksort($diff);
 
             throw new UndefinedOptionsException(sprintf(
-                (count($diff) > 1 ? 'The options "%s" do not exist.' : 'The option "%s" does not exist.').' Defined options are: "%s".',
+                (\count($diff) > 1 ? 'The options "%s" do not exist.' : 'The option "%s" does not exist.').' Defined options are: "%s".',
                 implode('", "', array_keys($diff)),
                 implode('", "', array_keys($clone->defined))
             ));
@@ -738,11 +738,11 @@ public function resolve(array $options = array())
         // Check whether any required option is missing
         $diff = array_diff_key($clone->required, $clone->defaults);
 
-        if (count($diff) > 0) {
+        if (\count($diff) > 0) {
             ksort($diff);
 
             throw new MissingOptionsException(sprintf(
-                count($diff) > 1 ? 'The required options "%s" are missing.' : 'The required option "%s" is missing.',
+                \count($diff) > 1 ? 'The required options "%s" are missing.' : 'The required option "%s" is missing.',
                 implode('", "', array_keys($diff))
             ));
         }
@@ -882,7 +882,7 @@ public function offsetGet($option)
                     $this->formatValue($value)
                 );
 
-                if (count($printableAllowedValues) > 0) {
+                if (\count($printableAllowedValues) > 0) {
                     $message .= sprintf(
                         ' Accepted values are: %s.',
                         $this->formatValues($printableAllowedValues)
@@ -1049,7 +1049,7 @@ public function count()
             throw new AccessException('Counting is only supported within closures of lazy options and normalizers.');
         }
 
-        return count($this->defaults);
+        return \count($this->defaults);
     }
 
     /**
@@ -1088,7 +1088,7 @@ private function formatTypeOf($value, ?string $type): string
             }
         }
 
-        return (\is_object($value) ? get_class($value) : gettype($value)).$suffix;
+        return (\is_object($value) ? \get_class($value) : \gettype($value)).$suffix;
     }
 
     /**
@@ -1103,7 +1103,7 @@ private function formatTypeOf($value, ?string $type): string
     private function formatValue($value): string
     {
         if (\is_object($value)) {
-            return get_class($value);
+            return \get_class($value);
         }
 
         if (\is_array($value)) {
@@ -1152,7 +1152,7 @@ private function formatValues(array $values): string
 
     private static function isValueValidType(string $type, $value): bool
     {
-        return (function_exists($isFunction = 'is_'.$type) && $isFunction($value)) || $value instanceof $type;
+        return (\function_exists($isFunction = 'is_'.$type) && $isFunction($value)) || $value instanceof $type;
     }
 
     private function getInvalidValues(array $arrayValues, string $type): array

Tests/OptionsResolverTest.php

@@ -1765,7 +1765,7 @@ public function testCountFailsOutsideResolve()
         $this->resolver->setDefined('bar');
         $this->resolver->setDefault('lazy1', function () {});
 
-        count($this->resolver);
+        \count($this->resolver);
     }
 
     public function testNestedArrays()