[Notifier] Add from in SmsMessage and support it in bridge transports

Author: alamirault

CHANGELOG.md

@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add PHPUnit constraints
+ * Add `from` property in `SmsMessage`
 
 6.1
 ---

Message/SmsMessage.php

@@ -23,15 +23,17 @@ class SmsMessage implements MessageInterface
     private ?string $transport = null;
     private string $subject;
     private string $phone;
+    private string $from;
 
-    public function __construct(string $phone, string $subject)
+    public function __construct(string $phone, string $subject, string $from = '')
     {
         if ('' === $phone) {
             throw new InvalidArgumentException(sprintf('"%s" needs a phone number, it cannot be empty.', __CLASS__));
         }
 
         $this->subject = $subject;
         $this->phone = $phone;
+        $this->from = $from;
     }
 
     public static function fromNotification(Notification $notification, SmsRecipientInterface $recipient): self
@@ -93,6 +95,21 @@ public function getTransport(): ?string
         return $this->transport;
     }
 
+    /**
+     * @return $this
+     */
+    public function from(string $from): static
+    {
+        $this->from = $from;
+
+        return $this;
+    }
+
+    public function getFrom(): string
+    {
+        return $this->from;
+    }
+
     public function getOptions(): ?MessageOptionsInterface
     {
         return null;

Tests/Message/SmsMessageTest.php

@@ -25,6 +25,16 @@ public function testCanBeConstructed()
 
         $this->assertSame('subject', $message->getSubject());
         $this->assertSame('+3312345678', $message->getPhone());
+        $this->assertSame('', $message->getFrom());
+    }
+
+    public function testCanBeConstructedWithFrom()
+    {
+        $message = new SmsMessage('+3312345678', 'subject', 'foo');
+
+        $this->assertSame('subject', $message->getSubject());
+        $this->assertSame('+3312345678', $message->getPhone());
+        $this->assertSame('foo', $message->getFrom());
     }
 
     public function testEnsureNonEmptyPhoneOnConstruction()
@@ -57,4 +67,15 @@ public function testEnsureNonEmptyPhoneOnSet()
 
         $message->phone('');
     }
+
+    public function testSetFrom()
+    {
+        $message = new SmsMessage('+3312345678', 'subject');
+
+        $this->assertSame('', $message->getFrom());
+
+        $message->from('foo');
+
+        $this->assertSame('foo', $message->getFrom());
+    }
 }