feature #303 Fixed PHPUnit Warning (lyrixx)

lyrixx · lyrixx · commit a6c3267a149f · 2019-05-16T13:47:20.000+02:00
This PR was merged into the 3.x-dev branch. Discussion ---------- Fixed PHPUnit Warning Commits ------- 9f8e531 Fixed PHPUnit Warning
diff --git a/.travis.yml b/.travis.yml
@@ -26,6 +26,8 @@ matrix:
       env: SYMFONY_VERSION="3.4.*" DEPENDENCIES=dev
     - php: 7.0
     - php: 7.1
+      # There is a bug in PHPUnit 5.7
+      env: SYMFONY_PHPUNIT_VERSION=6.5
     - php: 7.2
     - php: 7.3
     # Test against dev versions
diff --git a/Tests/DependencyInjection/Compiler/LoggerChannelPassTest.php b/Tests/DependencyInjection/Compiler/LoggerChannelPassTest.php
@@ -140,6 +140,9 @@ public function testChannelsConfigurationOptionSupportsAppChannel()
 
         $container->setParameter('monolog.additional_channels', array('app'));
         $container->compile();
+
+        // the test ensures that the validation does not fail (i.e. it does not throw any exceptions)
+        $this->addToAssertionCount(1);
     }
 
     private function getContainer()

Original file line number	Diff line number	Diff line change
`@@ -140,6 +140,9 @@ public function testChannelsConfigurationOptionSupportsAppChannel()`
`140`	`140`
`141`	`141`	`$container->setParameter('monolog.additional_channels', array('app'));`
`142`	`142`	`$container->compile();`
	`143`	`+`
	`144`	`+ // the test ensures that the validation does not fail (i.e. it does not throw any exceptions)`
	`145`	`+ $this->addToAssertionCount(1);`
`143`	`146`	`}`
`144`	`147`
`145`	`148`	`private function getContainer()`