[Messenger] DoctrineTransport - Use InvalidArgumentException instead of TransportException during configuration checks

Author: vincenttouzet

Tests/Transport/Doctrine/ConnectionTest.php

@@ -213,15 +213,15 @@ public function buildConfigurationProvider()
     }
 
     /**
-     * @expectedException \Symfony\Component\Messenger\Exception\TransportException
+     * @expectedException \Symfony\Component\Messenger\Exception\InvalidArgumentException
      */
     public function testItThrowsAnExceptionIfAnExtraOptionsInDefined()
     {
         Connection::buildConfiguration('doctrine://default', ['new_option' => 'woops']);
     }
 
     /**
-     * @expectedException \Symfony\Component\Messenger\Exception\TransportException
+     * @expectedException \Symfony\Component\Messenger\Exception\InvalidArgumentException
      */
     public function testItThrowsAnExceptionIfAnExtraOptionsInDefinedInDSN()
     {

Transport/Doctrine/Connection.php

@@ -87,13 +87,13 @@ public static function buildConfiguration($dsn, array $options = [])
         // check for extra keys in options
         $optionsExtraKeys = array_diff(array_keys($options), array_keys($configuration));
         if (0 < \count($optionsExtraKeys)) {
-            throw new TransportException(sprintf('Unknown option found : [%s]. Allowed options are [%s]', implode(', ', $optionsExtraKeys), implode(', ', self::DEFAULT_OPTIONS)));
+            throw new InvalidArgumentException(sprintf('Unknown option found : [%s]. Allowed options are [%s]', implode(', ', $optionsExtraKeys), implode(', ', self::DEFAULT_OPTIONS)));
         }
 
         // check for extra keys in options
         $queryExtraKeys = array_diff(array_keys($query), array_keys($configuration));
         if (0 < \count($queryExtraKeys)) {
-            throw new TransportException(sprintf('Unknown option found in DSN: [%s]. Allowed options are [%s]', implode(', ', $queryExtraKeys), implode(', ', self::DEFAULT_OPTIONS)));
+            throw new InvalidArgumentException(sprintf('Unknown option found in DSN: [%s]. Allowed options are [%s]', implode(', ', $queryExtraKeys), implode(', ', self::DEFAULT_OPTIONS)));
         }
 
         return $configuration;