Merge branch '4.4' into 5.1

* 4.4:
  Cleanup CI scripts
  fix code style
  fix code style
  take query and request parameters into account when matching routes
  mistake
  fix tests to run assertions on returned Crawler instances

Author: xabbuh

Test/TransportFactoryTestCase.php

@@ -54,7 +54,7 @@ public function incompleteDsnProvider(): iterable
     /**
      * @dataProvider supportsProvider
      */
-    public function testSupports(Dsn $dsn, bool $supports): void
+    public function testSupports(Dsn $dsn, bool $supports)
     {
         $factory = $this->getFactory();
 
@@ -64,7 +64,7 @@ public function testSupports(Dsn $dsn, bool $supports): void
     /**
      * @dataProvider createProvider
      */
-    public function testCreate(Dsn $dsn, TransportInterface $transport): void
+    public function testCreate(Dsn $dsn, TransportInterface $transport)
     {
         $factory = $this->getFactory();
 
@@ -77,7 +77,7 @@ public function testCreate(Dsn $dsn, TransportInterface $transport): void
     /**
      * @dataProvider unsupportedSchemeProvider
      */
-    public function testUnsupportedSchemeException(Dsn $dsn, string $message = null): void
+    public function testUnsupportedSchemeException(Dsn $dsn, string $message = null)
     {
         $factory = $this->getFactory();
 
@@ -92,7 +92,7 @@ public function testUnsupportedSchemeException(Dsn $dsn, string $message = null)
     /**
      * @dataProvider incompleteDsnProvider
      */
-    public function testIncompleteDsnException(Dsn $dsn): void
+    public function testIncompleteDsnException(Dsn $dsn)
     {
         $factory = $this->getFactory();
 

Tests/TransportTest.php

@@ -27,7 +27,7 @@ class TransportTest extends TestCase
     /**
      * @dataProvider fromStringProvider
      */
-    public function testFromString(string $dsn, TransportInterface $transport): void
+    public function testFromString(string $dsn, TransportInterface $transport)
     {
         $transportFactory = new Transport([new DummyTransportFactory()]);
 
@@ -63,7 +63,7 @@ public function fromStringProvider(): iterable
     /**
      * @dataProvider fromDsnProvider
      */
-    public function testFromDsn(string $dsn, TransportInterface $transport): void
+    public function testFromDsn(string $dsn, TransportInterface $transport)
     {
         $this->assertEquals($transport, Transport::fromDsn($dsn));
     }
@@ -79,7 +79,7 @@ public function fromDsnProvider(): iterable
     /**
      * @dataProvider fromWrongStringProvider
      */
-    public function testFromWrongString(string $dsn, string $error): void
+    public function testFromWrongString(string $dsn, string $error)
     {
         $transportFactory = new Transport([new DummyTransportFactory()]);
 
@@ -116,7 +116,7 @@ public function send(RawMessage $message, Envelope $envelope = null): ?SentMessa
 
     public function __toString(): string
     {
-        return sprintf('dummy://local');
+        return 'dummy://local';
     }
 }