Remove unused code and unnecessary else branches

alexandre-daubois · alexandre-daubois · commit 664a334085d1 · 2024-08-02T08:50:04.000+02:00
diff --git a/Transport/Smtp/Auth/CramMd5Authenticator.php b/Transport/Smtp/Auth/CramMd5Authenticator.php
@@ -58,8 +58,7 @@ private function getResponse(#[\SensitiveParameter] string $secret, string $chal
         $kopad = substr($secret, 0, 64) ^ str_repeat(\chr(0x5C), 64);
 
         $inner = pack('H32', md5($kipad.$challenge));
-        $digest = md5($kopad.$inner);
 
-        return $digest;
+        return md5($kopad.$inner);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,7 @@ private function getResponse(#[\SensitiveParameter] string $secret, string $chal`
`58`	`58`	`$kopad = substr($secret, 0, 64) ^ str_repeat(\chr(0x5C), 64);`
`59`	`59`
`60`	`60`	`$inner = pack('H32', md5($kipad.$challenge));`
`61`		`- $digest = md5($kopad.$inner);`
`62`	`61`
`63`		`- return $digest;`
	`62`	`+ return md5($kopad.$inner);`
`64`	`63`	`}`
`65`	`64`	`}`