Merge branch '2.8' into 3.4

* 2.8:
  Fix Clidumper tests
  Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
  Apply fixers
  Disable the native_constant_invocation fixer until it can be scoped
  Update the list of excluded files for the CS fixer

Author: nicolas-grekas

Client.php

@@ -169,7 +169,7 @@ protected function getScript($request)
         foreach (get_declared_classes() as $class) {
             if (0 === strpos($class, 'ComposerAutoloaderInit')) {
                 $r = new \ReflectionClass($class);
-                $file = dirname(dirname($r->getFileName())).'/autoload.php';
+                $file = \dirname(\dirname($r->getFileName())).'/autoload.php';
                 if (file_exists($file)) {
                     $requires .= "require_once '".str_replace("'", "\\'", $file)."';\n";
                 }

Command/AboutCommand.php

@@ -69,7 +69,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             new TableSeparator(),
             array('<info>Kernel</>'),
             new TableSeparator(),
-            array('Type', get_class($kernel)),
+            array('Type', \get_class($kernel)),
             array('Name', $kernel->getName()),
             array('Environment', $kernel->getEnvironment()),
             array('Debug', $kernel->isDebug() ? 'true' : 'false'),
@@ -84,9 +84,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
             array('Architecture', (PHP_INT_SIZE * 8).' bits'),
             array('Intl locale', class_exists('Locale', false) && \Locale::getDefault() ? \Locale::getDefault() : 'n/a'),
             array('Timezone', date_default_timezone_get().' (<comment>'.(new \DateTime())->format(\DateTime::W3C).'</>)'),
-            array('OPcache', extension_loaded('Zend OPcache') && ini_get('opcache.enable') ? 'true' : 'false'),
-            array('APCu', extension_loaded('apcu') && ini_get('apc.enabled') ? 'true' : 'false'),
-            array('Xdebug', extension_loaded('xdebug') ? 'true' : 'false'),
+            array('OPcache', \extension_loaded('Zend OPcache') && ini_get('opcache.enable') ? 'true' : 'false'),
+            array('APCu', \extension_loaded('apcu') && ini_get('apc.enabled') ? 'true' : 'false'),
+            array('Xdebug', \extension_loaded('xdebug') ? 'true' : 'false'),
         );
 
         if ($dotenv = self::getDotenvVars()) {

Command/AbstractConfigCommand.php

@@ -109,7 +109,7 @@ public function validateConfiguration(ExtensionInterface $extension, $configurat
         }
 
         if (!$configuration instanceof ConfigurationInterface) {
-            throw new \LogicException(sprintf('Configuration class "%s" should implement ConfigurationInterface in order to be dumpable', get_class($configuration)));
+            throw new \LogicException(sprintf('Configuration class "%s" should implement ConfigurationInterface in order to be dumpable', \get_class($configuration)));
         }
     }
 

Command/AssetsInstallCommand.php

@@ -113,8 +113,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             if (!is_dir($targetArg)) {
                 // deprecated, logic to be removed in 4.0
                 // this allows the commands to work out of the box with web/ and public/
-                if (is_dir(dirname($targetArg).'/web')) {
-                    $targetArg = dirname($targetArg).'/web';
+                if (is_dir(\dirname($targetArg).'/web')) {
+                    $targetArg = \dirname($targetArg).'/web';
                 } else {
                     throw new InvalidArgumentException(sprintf('The target directory "%s" does not exist.', $input->getArgument('target')));
                 }
@@ -263,8 +263,8 @@ private function absoluteSymlinkWithFallback($originDir, $targetDir)
     private function symlink($originDir, $targetDir, $relative = false)
     {
         if ($relative) {
-            $this->filesystem->mkdir(dirname($targetDir));
-            $originDir = $this->filesystem->makePathRelative($originDir, realpath(dirname($targetDir)));
+            $this->filesystem->mkdir(\dirname($targetDir));
+            $originDir = $this->filesystem->makePathRelative($originDir, realpath(\dirname($targetDir)));
         }
         $this->filesystem->symlink($originDir, $targetDir);
         if (!file_exists($targetDir)) {

Command/CacheClearCommand.php

@@ -115,7 +115,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $this->getApplication()->setDispatcher(new EventDispatcher());
 
         $containerDir = new \ReflectionObject($kernel->getContainer());
-        $containerDir = basename(dirname($containerDir->getFileName()));
+        $containerDir = basename(\dirname($containerDir->getFileName()));
 
         // the warmup cache dir name must have the same length as the real one
         // to avoid the many problems in serialized resources files
@@ -147,7 +147,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         if ('/' === \DIRECTORY_SEPARATOR && $mounts = @file('/proc/mounts')) {
             foreach ($mounts as $mount) {
-                $mount = array_slice(explode(' ', $mount), 1, -3);
+                $mount = \array_slice(explode(' ', $mount), 1, -3);
                 if (!\in_array(array_pop($mount), array('vboxsf', 'nfs'))) {
                     continue;
                 }
@@ -201,7 +201,7 @@ protected function warmup($warmupDir, $realCacheDir, $enableOptionalWarmers = tr
             $tempKernel = $realKernel;
         } else {
             $this->warning = 'Calling "cache:clear" with a kernel that does not implement "Symfony\Component\HttpKernel\RebootableInterface" is deprecated since Symfony 3.4 and will be unsupported in 4.0.';
-            $realKernelClass = get_class($realKernel);
+            $realKernelClass = \get_class($realKernel);
             $namespace = '';
             if (false !== $pos = strrpos($realKernelClass, '\\')) {
                 $namespace = substr($realKernelClass, 0, $pos);
@@ -236,8 +236,8 @@ protected function warmup($warmupDir, $realCacheDir, $enableOptionalWarmers = tr
         }
 
         // fix references to the Kernel in .meta files
-        $safeTempKernel = str_replace('\\', '\\\\', get_class($tempKernel));
-        $realKernelFQN = get_class($realKernel);
+        $safeTempKernel = str_replace('\\', '\\\\', \get_class($tempKernel));
+        $realKernelFQN = \get_class($realKernel);
 
         foreach (Finder::create()->files()->depth('<3')->name('*.meta')->in($warmupDir) as $file) {
             file_put_contents($file, preg_replace(
@@ -255,7 +255,7 @@ protected function warmup($warmupDir, $realCacheDir, $enableOptionalWarmers = tr
             file_put_contents($file, $content);
             rename($file, str_replace(DIRECTORY_SEPARATOR.$tempContainerClass, DIRECTORY_SEPARATOR.$realContainerClass, $file));
         }
-        if (is_dir($tempContainerDir = $warmupDir.'/'.get_class($tempKernel->getContainer()))) {
+        if (is_dir($tempContainerDir = $warmupDir.'/'.\get_class($tempKernel->getContainer()))) {
             foreach (Finder::create()->files()->in($tempContainerDir) as $file) {
                 $content = str_replace($tempContainerClass, $realContainerClass, file_get_contents($file));
                 file_put_contents($file, $content);
@@ -285,7 +285,7 @@ protected function getTempKernel(KernelInterface $parent, $namespace, $parentCla
         $class = substr($parentClass, 0, -1).'_';
         // the temp container class must be changed too
         $container = $parent->getContainer();
-        $realContainerClass = var_export($container->hasParameter('kernel.container_class') ? $container->getParameter('kernel.container_class') : get_class($parent->getContainer()), true);
+        $realContainerClass = var_export($container->hasParameter('kernel.container_class') ? $container->getParameter('kernel.container_class') : \get_class($parent->getContainer()), true);
         $containerClass = substr_replace($realContainerClass, '_', -2, 1);
 
         if (method_exists($parent, 'getProjectDir')) {

Command/ContainerDebugCommand.php

@@ -190,7 +190,7 @@ protected function getContainerBuilder()
         $kernel = $this->getApplication()->getKernel();
 
         if (!$kernel->isDebug() || !(new ConfigCache($kernel->getContainer()->getParameter('debug.container.dump'), true))->isFresh()) {
-            $buildContainer = \Closure::bind(function () { return $this->buildContainer(); }, $kernel, get_class($kernel));
+            $buildContainer = \Closure::bind(function () { return $this->buildContainer(); }, $kernel, \get_class($kernel));
             $container = $buildContainer();
             $container->getCompilerPassConfig()->setRemovingPasses(array());
             $container->compile();
@@ -212,7 +212,7 @@ private function findProperServiceName(InputInterface $input, SymfonyStyle $io,
             throw new InvalidArgumentException(sprintf('No services found that match "%s".', $name));
         }
 
-        $default = 1 === count($matchingServices) ? $matchingServices[0] : null;
+        $default = 1 === \count($matchingServices) ? $matchingServices[0] : null;
 
         return $io->choice('Select one of the following services to display its information', $matchingServices, $default);
     }

Command/RouterDebugCommand.php

@@ -165,7 +165,7 @@ private function extractCallable(Route $route)
         if (1 === substr_count($controller, ':')) {
             list($service, $method) = explode(':', $controller);
             try {
-                return sprintf('%s::%s', get_class($this->getApplication()->getKernel()->getContainer()->get($service)), $method);
+                return sprintf('%s::%s', \get_class($this->getApplication()->getKernel()->getContainer()->get($service)), $method);
             } catch (ServiceNotFoundException $e) {
             }
         }

Command/TranslationDebugCommand.php

@@ -250,8 +250,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
                     $states[] = self::MESSAGE_UNUSED;
                 }
 
-                if (!in_array(self::MESSAGE_UNUSED, $states) && true === $input->getOption('only-unused')
-                    || !in_array(self::MESSAGE_MISSING, $states) && true === $input->getOption('only-missing')) {
+                if (!\in_array(self::MESSAGE_UNUSED, $states) && true === $input->getOption('only-unused')
+                    || !\in_array(self::MESSAGE_MISSING, $states) && true === $input->getOption('only-missing')) {
                     continue;
                 }
 
@@ -315,7 +315,7 @@ private function sanitizeString($string, $length = 40)
             if (mb_strlen($string, $encoding) > $length) {
                 return mb_substr($string, 0, $length - 3, $encoding).'...';
             }
-        } elseif (strlen($string) > $length) {
+        } elseif (\strlen($string) > $length) {
             return substr($string, 0, $length - 3).'...';
         }
 

Command/TranslationUpdateCommand.php

@@ -152,7 +152,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // check format
         $supportedFormats = $this->writer->getFormats();
-        if (!in_array($input->getOption('output-format'), $supportedFormats)) {
+        if (!\in_array($input->getOption('output-format'), $supportedFormats)) {
             $errorIo->error(array('Wrong output format', 'Supported formats are: '.implode(', ', $supportedFormats).'.'));
 
             return 1;
@@ -237,7 +237,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             : new MergeOperation($currentCatalogue, $extractedCatalogue);
 
         // Exit if no messages found.
-        if (!count($operation->getDomains())) {
+        if (!\count($operation->getDomains())) {
             $errorIo->warning('No translation messages were found.');
 
             return;
@@ -263,7 +263,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                     }, array_keys($operation->getObsoleteMessages($domain)))
                 );
 
-                $domainMessagesCount = count($list);
+                $domainMessagesCount = \count($list);
 
                 $io->section(sprintf('Messages extracted for domain "<info>%s</info>" (%d message%s)', $domain, $domainMessagesCount, $domainMessagesCount > 1 ? 's' : ''));
                 $io->listing($list);

Command/XliffLintCommand.php

@@ -28,7 +28,7 @@ class XliffLintCommand extends BaseLintCommand
 
     public function __construct($name = null, $directoryIteratorProvider = null, $isReadableProvider = null)
     {
-        if (func_num_args()) {
+        if (\func_num_args()) {
             @trigger_error(sprintf('Passing a constructor argument in "%s()" is deprecated since Symfony 3.4 and will be removed in 4.0. If the command was registered by convention, make it a service instead.', __METHOD__), E_USER_DEPRECATED);
         }