Skip to content

Commit b57c001

Browse files
minor #61372 chore: PHP CS Fixer - update heredoc handling (keradus)
This PR was merged into the 7.4 branch. Discussion ---------- chore: PHP CS Fixer - update heredoc handling | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix CS <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Inspired while #61371 , but can be merged separately. ``@PHPxMigration`` and ``@Symfony`` ruleset have different config for those rules. I assume the difference is coming from supporting pre-7.2 PHP version earlier in the codebase, where heredoc closure and trailing comma had to be on separated lines - but it's no longer the case. Can we benefit from newer PHP syntax and incorporate those changes? (yes, `trailing_comma_in_multiline`, part of ``@Symfony``, is already having this enabled!) if so, i will also merge them into ``@Symfony`` ruleset itself afterwards. with love by [PHP Coding Standards Fixer](https://cs.symfony.com/) Commits ------- f9956227bb6 chore: PHP CS Fixer - update heredoc handling
2 parents 12d370b + ef248dd commit b57c001

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

Tests/Functional/ConfigDumpReferenceCommandTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,9 @@ public function testDumpAtPath(bool $debug)
9595
child2: ~
9696

9797

98-
EOL
99-
, $tester->getDisplay(true));
98+
EOL,
99+
$tester->getDisplay(true)
100+
);
100101
}
101102

102103
#[TestWith([true])]

Tests/Functional/ContainerDebugCommandTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,9 @@ public function testDescribeEnvVars()
183183
184184
* UNKNOWN
185185

186-
TXT
187-
, $tester->getDisplay(true));
186+
TXT,
187+
$tester->getDisplay(true)
188+
);
188189

189190
putenv('REAL');
190191
}

Tests/Functional/FragmentTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,9 @@ public function testFragment($insulate)
3333
es
3434
--
3535
fr
36-
TXT
37-
, $client->getResponse()->getContent());
36+
TXT,
37+
$client->getResponse()->getContent()
38+
);
3839
}
3940

4041
public static function getConfigs()

0 commit comments

Comments
 (0)