Removing the Controller::getUser() deprecation

Author: weaverryan

CHANGELOG.md

@@ -11,8 +11,6 @@ CHANGELOG
  * Removed `symfony/asset` from the list of required dependencies in `composer.json`
  * The `Resources/public/images/*` files have been removed.
  * The `Resources/public/css/*.css` files have been removed (they are now inlined in TwigBundle).
- * The `Controller::getUser()` method has been deprecated and will be removed in
-   Symfony 4.0; typehint the security user object in the action instead.
  * Added possibility to prioritize form type extensions with `'priority'` attribute on tags `form.type_extension` 
 
 3.1.0

Controller/Controller.php

@@ -22,7 +22,6 @@
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\HttpKernel\HttpKernelInterface;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
-use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Csrf\CsrfToken;
 use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\Form\Form;
@@ -367,16 +366,12 @@ protected function getDoctrine()
      *
      * @return mixed
      *
-     * @deprecated as of 3.2 and will be removed in 4.0. You can typehint your method argument with Symfony\Component\Security\Core\User\UserInterface instead.
-     *
      * @throws \LogicException If SecurityBundle is not available
      *
      * @see TokenInterface::getUser()
      */
     protected function getUser()
     {
-        @trigger_error(sprintf('%s() is deprecated as of 3.2 and will be removed in 4.0. You can typehint your method argument with %s instead.', __METHOD__, UserInterface::class), E_USER_DEPRECATED);
-
         if (!$this->container->has('security.token_storage')) {
             throw new \LogicException('The SecurityBundle is not registered in your application.');
         }

Tests/Controller/ControllerTest.php

@@ -56,9 +56,6 @@ public function testForward()
         $this->assertEquals('xml--fr', $response->getContent());
     }
 
-    /**
-     * @group legacy
-     */
     public function testGetUser()
     {
         $user = new User('user', 'pass');
@@ -70,9 +67,6 @@ public function testGetUser()
         $this->assertSame($controller->getUser(), $user);
     }
 
-    /**
-     * @group legacy
-     */
     public function testGetUserAnonymousUserConvertedToNull()
     {
         $token = new AnonymousToken('default', 'anon.');
@@ -83,9 +77,6 @@ public function testGetUserAnonymousUserConvertedToNull()
         $this->assertNull($controller->getUser());
     }
 
-    /**
-     * @group legacy
-     */
     public function testGetUserWithEmptyTokenStorage()
     {
         $controller = new TestController();
@@ -95,7 +86,6 @@ public function testGetUserWithEmptyTokenStorage()
     }
 
     /**
-     * @group legacy
      * @expectedException \LogicException
      * @expectedExceptionMessage The SecurityBundle is not registered in your application.
      */