Merge branch '3.3' into 3.4

nicolas-grekas · nicolas-grekas · commit afdfb4ef4daa · 2017-09-15T12:12:22.000+02:00
* 3.3:
  [CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction
  [Filesystem] mirror - fix copying content with same name as source/target.
  Removed unnecessary getDefinition() call.
  .php_cs.dist - simplify config
  [WebProfilerBundle] fixed TemplateManager when using Twig 2 without compat interfaces
diff --git a/Command/ConfigDumpReferenceCommand.php b/Command/ConfigDumpReferenceCommand.php
@@ -97,7 +97,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $format = $input->getOption('format');
         $path = $input->getArgument('path');
 
-        if ($path !== null && 'yaml' !== $format) {
+        if (null !== $path && 'yaml' !== $format) {
             $errorIo->error('The "path" option is only available for the "yaml" format.');
 
             return 1;
@@ -109,7 +109,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $message = sprintf('Default configuration for "%s"', $name);
         }
 
-        if ($path !== null) {
+        if (null !== $path) {
             $message .= sprintf(' at path "%s"', $path);
         }
 
diff --git a/Command/TranslationUpdateCommand.php b/Command/TranslationUpdateCommand.php
@@ -136,7 +136,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $errorIo = $io->getErrorStyle();
 
         // check presence of force or dump-message
-        if ($input->getOption('force') !== true && $input->getOption('dump-messages') !== true) {
+        if (true !== $input->getOption('force') && true !== $input->getOption('dump-messages')) {
             $errorIo->error('You must choose one of --force or --dump-messages');
 
             return 1;
@@ -250,19 +250,19 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $extractedMessagesCount += $domainMessagesCount;
             }
 
-            if ($input->getOption('output-format') == 'xlf') {
+            if ('xlf' == $input->getOption('output-format')) {
                 $errorIo->comment('Xliff output version is <info>1.2</info>');
             }
 
             $resultMessage = sprintf('%d message%s successfully extracted', $extractedMessagesCount, $extractedMessagesCount > 1 ? 's were' : ' was');
         }
 
-        if ($input->getOption('no-backup') === true) {
+        if (true === $input->getOption('no-backup')) {
             $this->writer->disableBackup();
         }
 
         // save the files
-        if ($input->getOption('force') === true) {
+        if (true === $input->getOption('force')) {
             $errorIo->comment('Writing files...');
 
             $bundleTransPath = false;
diff --git a/Controller/ControllerTrait.php b/Controller/ControllerTrait.php
@@ -136,7 +136,7 @@ protected function json($data, $status = 200, $headers = array(), $context = arr
     protected function file($file, $fileName = null, $disposition = ResponseHeaderBag::DISPOSITION_ATTACHMENT)
     {
         $response = new BinaryFileResponse($file);
-        $response->setContentDisposition($disposition, $fileName === null ? $response->getFile()->getFilename() : $fileName);
+        $response->setContentDisposition($disposition, null === $fileName ? $response->getFile()->getFilename() : $fileName);
 
         return $response;
     }
diff --git a/Controller/RedirectController.php b/Controller/RedirectController.php
@@ -103,7 +103,7 @@ public function urlRedirectAction(Request $request, $path, $permanent = false, $
 
         $qs = $request->getQueryString();
         if ($qs) {
-            if (strpos($path, '?') === false) {
+            if (false === strpos($path, '?')) {
                 $qs = '?'.$qs;
             } else {
                 $qs = '&'.$qs;
diff --git a/Controller/TemplateController.php b/Controller/TemplateController.php
@@ -54,7 +54,7 @@ public function templateAction($template, $maxAge = null, $sharedAge = null, $pr
 
         if ($private) {
             $response->setPrivate();
-        } elseif ($private === false || (null === $private && ($maxAge || $sharedAge))) {
+        } elseif (false === $private || (null === $private && ($maxAge || $sharedAge))) {
             $response->setPublic();
         }
 
diff --git a/DependencyInjection/FrameworkExtension.php b/DependencyInjection/FrameworkExtension.php
@@ -631,9 +631,9 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
 
             $transitions = array();
             foreach ($workflow['transitions'] as $transition) {
-                if ($type === 'workflow') {
+                if ('workflow' === $type) {
                     $transitions[] = new Definition(Workflow\Transition::class, array($transition['name'], $transition['from'], $transition['to']));
-                } elseif ($type === 'state_machine') {
+                } elseif ('state_machine' === $type) {
                     foreach ($transition['from'] as $from) {
                         foreach ($transition['to'] as $to) {
                             $transitions[] = new Definition(Workflow\Transition::class, array($transition['name'], $from, $to));
diff --git a/Resources/views/FormTable/button_row.html.php b/Resources/views/FormTable/button_row.html.php
@@ -1,6 +1,6 @@
 <tr>
     <td></td>
     <td>
-        <?php echo $view['form']->widget($form) ?>
+        <?php echo $view['form']->widget($form); ?>
     </td>
 </tr>
diff --git a/Resources/views/FormTable/form_row.html.php b/Resources/views/FormTable/form_row.html.php
@@ -1,9 +1,9 @@
 <tr>
     <td>
-        <?php echo $view['form']->label($form) ?>
+        <?php echo $view['form']->label($form); ?>
     </td>
     <td>
-        <?php echo $view['form']->errors($form) ?>
-        <?php echo $view['form']->widget($form) ?>
+        <?php echo $view['form']->errors($form); ?>
+        <?php echo $view['form']->widget($form); ?>
     </td>
 </tr>
diff --git a/Resources/views/FormTable/form_widget_compound.html.php b/Resources/views/FormTable/form_widget_compound.html.php
@@ -1,11 +1,11 @@
-<table <?php echo $view['form']->block($form, 'widget_container_attributes') ?>>
+<table <?php echo $view['form']->block($form, 'widget_container_attributes'); ?>>
     <?php if (!$form->parent && $errors): ?>
     <tr>
         <td colspan="2">
-            <?php echo $view['form']->errors($form) ?>
+            <?php echo $view['form']->errors($form); ?>
         </td>
     </tr>
-    <?php endif ?>
-    <?php echo $view['form']->block($form, 'form_rows') ?>
-    <?php echo $view['form']->rest($form) ?>
+    <?php endif; ?>
+    <?php echo $view['form']->block($form, 'form_rows'); ?>
+    <?php echo $view['form']->rest($form); ?>
 </table>
diff --git a/Resources/views/FormTable/hidden_row.html.php b/Resources/views/FormTable/hidden_row.html.php
@@ -1,5 +1,5 @@
 <tr style="display: none">
     <td colspan="2">
-        <?php echo $view['form']->widget($form) ?>
+        <?php echo $view['form']->widget($form); ?>
     </td>
 </tr>
diff --git a/Test/KernelTestCase.php b/Test/KernelTestCase.php
@@ -86,7 +86,7 @@ private static function getPhpUnitCliConfigArgument()
         $dir = null;
         $reversedArgs = array_reverse($_SERVER['argv']);
         foreach ($reversedArgs as $argIndex => $testArg) {
-            if (preg_match('/^-[^ \-]*c$/', $testArg) || $testArg === '--configuration') {
+            if (preg_match('/^-[^ \-]*c$/', $testArg) || '--configuration' === $testArg) {
                 $dir = realpath($reversedArgs[$argIndex - 1]);
                 break;
             } elseif (0 === strpos($testArg, '--configuration=')) {
diff --git a/Tests/Templating/Helper/Fixtures/StubTemplateNameParser.php b/Tests/Templating/Helper/Fixtures/StubTemplateNameParser.php
@@ -30,9 +30,9 @@ public function parse($name)
     {
         list($bundle, $controller, $template) = explode(':', $name, 3);
 
-        if ($template[0] == '_') {
+        if ('_' == $template[0]) {
             $path = $this->rootTheme.'/Custom/'.$template;
-        } elseif ($bundle === 'TestBundle') {
+        } elseif ('TestBundle' === $bundle) {
             $path = $this->rootTheme.'/'.$controller.'/'.$template;
         } else {
             $path = $this->root.'/'.$controller.'/'.$template;
diff --git a/Tests/Templating/Helper/Resources/Child/form_label.html.php b/Tests/Templating/Helper/Resources/Child/form_label.html.php
@@ -1 +1 @@
-<label><?php echo $global ?>child</label>
+<label><?php echo $global; ?>child</label>
diff --git a/Tests/Templating/Helper/Resources/Parent/form_widget_simple.html.php b/Tests/Templating/Helper/Resources/Parent/form_widget_simple.html.php
@@ -1,2 +1,2 @@
-<?php $type = isset($type) ? $type : 'text' ?>
-<input type="<?php echo $type ?>" <?php $view['form']->block($form, 'widget_attributes') ?> value="<?php echo $value ?>" rel="theme" />
+<?php $type = isset($type) ? $type : 'text'; ?>
+<input type="<?php echo $type; ?>" <?php $view['form']->block($form, 'widget_attributes'); ?> value="<?php echo $value; ?>" rel="theme" />
diff --git a/Tests/Templating/TemplateFilenameParserTest.php b/Tests/Templating/TemplateFilenameParserTest.php
@@ -36,7 +36,7 @@ public function testParseFromFilename($file, $ref)
     {
         $template = $this->parser->parse($file);
 
-        if ($ref === false) {
+        if (false === $ref) {
             $this->assertFalse($template);
         } else {
             $this->assertEquals($template->getLogicalName(), $ref->getLogicalName());

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`97`	`97`	`$format = $input->getOption('format');`
`98`	`98`	`$path = $input->getArgument('path');`
`99`	`99`
`100`		`- if ($path !== null && 'yaml' !== $format) {`
	`100`	`+ if (null !== $path && 'yaml' !== $format) {`
`101`	`101`	`$errorIo->error('The "path" option is only available for the "yaml" format.');`
`102`	`102`
`103`	`103`	`return 1;`
`@@ -109,7 +109,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`109`	`109`	`$message = sprintf('Default configuration for "%s"', $name);`
`110`	`110`	`}`
`111`	`111`
`112`		`- if ($path !== null) {`
	`112`	`+ if (null !== $path) {`
`113`	`113`	`$message .= sprintf(' at path "%s"', $path);`
`114`	`114`	`}`
`115`	`115`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`136`	`136`	`$errorIo = $io->getErrorStyle();`
`137`	`137`
`138`	`138`	`// check presence of force or dump-message`
`139`		`- if ($input->getOption('force') !== true && $input->getOption('dump-messages') !== true) {`
	`139`	`+ if (true !== $input->getOption('force') && true !== $input->getOption('dump-messages')) {`
`140`	`140`	`$errorIo->error('You must choose one of --force or --dump-messages');`
`141`	`141`
`142`	`142`	`return 1;`
`@@ -250,19 +250,19 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`250`	`250`	`$extractedMessagesCount += $domainMessagesCount;`
`251`	`251`	`}`
`252`	`252`
`253`		`- if ($input->getOption('output-format') == 'xlf') {`
	`253`	`+ if ('xlf' == $input->getOption('output-format')) {`
`254`	`254`	`$errorIo->comment('Xliff output version is <info>1.2</info>');`
`255`	`255`	`}`
`256`	`256`
`257`	`257`	`$resultMessage = sprintf('%d message%s successfully extracted', $extractedMessagesCount, $extractedMessagesCount > 1 ? 's were' : ' was');`
`258`	`258`	`}`
`259`	`259`
`260`		`- if ($input->getOption('no-backup') === true) {`
	`260`	`+ if (true === $input->getOption('no-backup')) {`
`261`	`261`	`$this->writer->disableBackup();`
`262`	`262`	`}`
`263`	`263`
`264`	`264`	`// save the files`
`265`		`- if ($input->getOption('force') === true) {`
	`265`	`+ if (true === $input->getOption('force')) {`
`266`	`266`	`$errorIo->comment('Writing files...');`
`267`	`267`
`268`	`268`	`$bundleTransPath = false;`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function templateAction($template, $maxAge = null, $sharedAge = null, $pr`
`54`	`54`
`55`	`55`	`if ($private) {`
`56`	`56`	`$response->setPrivate();`
`57`		`- } elseif ($private === false \|\| (null === $private && ($maxAge \|\| $sharedAge))) {`
	`57`	`+ } elseif (false === $private \|\| (null === $private && ($maxAge \|\| $sharedAge))) {`
`58`	`58`	`$response->setPublic();`
`59`	`59`	`}`
`60`	`60`