Merge branch '3.4'

* 3.4:
  [HttpKernel] Disable container inlining when legacy inlining has been used
  Let getFlashes starts the session
  Update default translations path
  [FrameworkBundle] Ignore failures when removing the old cache dir

Author: nicolas-grekas

Command/CacheClearCommand.php

@@ -17,6 +17,7 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\EventDispatcher\EventDispatcher;
+use Symfony\Component\Filesystem\Exception\IOException;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\HttpKernel\CacheClearer\CacheClearerInterface;
 use Symfony\Component\HttpKernel\RebootableInterface;
@@ -104,7 +105,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $io->comment('Removing old cache directory...');
         }
 
-        $this->filesystem->remove($oldCacheDir);
+        try {
+            $this->filesystem->remove($oldCacheDir);
+        } catch (IOException $e) {
+            $io->warning($e->getMessage());
+        }
 
         if ($output->isVerbose()) {
             $io->comment('Finished');

DependencyInjection/Configuration.php

@@ -626,7 +626,7 @@ private function addTranslatorSection(ArrayNodeDefinition $rootNode)
                         ->scalarNode('formatter')->defaultValue('translator.formatter.default')->end()
                         ->scalarNode('default_path')
                             ->info('The default path used to load translations')
-                            ->defaultValue('%kernel.project_dir%/config/translations')
+                            ->defaultValue('%kernel.project_dir%/translations')
                         ->end()
                         ->arrayNode('paths')
                             ->prototype('scalar')->end()

Tests/DependencyInjection/ConfigurationTest.php

@@ -155,7 +155,7 @@ protected static function getBundleDefaultConfig()
                 'logging' => true,
                 'formatter' => 'translator.formatter.default',
                 'paths' => array(),
-                'default_path' => '%kernel.project_dir%/config/translations',
+                'default_path' => '%kernel.project_dir%/translations',
             ),
             'validation' => array(
                 'enabled' => !class_exists(FullStack::class),

Tests/DependencyInjection/Fixtures/yml/full.yml

@@ -42,7 +42,7 @@ framework:
     translator:
         enabled:  true
         fallback: fr
-        default_path: '%kernel.root_dir%/config/translations'
+        default_path: '%kernel.root_dir%/translations'
         paths: ['%kernel.root_dir%/Fixtures/translations']
     validation:
         enabled: true

Tests/DependencyInjection/FrameworkExtensionTest.php

@@ -496,7 +496,7 @@ public function testTranslator()
             '->registerTranslatorConfiguration() finds translation resources in custom paths'
         );
         $this->assertContains(
-            strtr(__DIR__.'/config/translations/test_default.en.xlf', '/', DIRECTORY_SEPARATOR),
+            strtr(__DIR__.'/translations/test_default.en.xlf', '/', DIRECTORY_SEPARATOR),
             $files,
             '->registerTranslatorConfiguration() finds translation resources in default path'
         );