disable the assets helper when assets are disabled

Author: xabbuh

DependencyInjection/FrameworkExtension.php

@@ -547,7 +547,11 @@ private function registerTemplatingConfiguration(array $config, $ide, ContainerB
                 'Symfony\\Bundle\\FrameworkBundle\\Templating\\Loader\\FilesystemLoader',
             ));
 
-            $container->getDefinition('templating.helper.assets')->replaceArgument(0, new Reference('assets.packages'));
+            if ($container->has('assets.packages')) {
+                $container->getDefinition('templating.helper.assets')->replaceArgument(0, new Reference('assets.packages'));
+            } else {
+                $container->removeDefinition('templating.helper.assets');
+            }
         }
     }
 

Tests/DependencyInjection/Fixtures/php/templating_no_assets.php

@@ -0,0 +1,7 @@
+<?php
+
+$container->loadFromExtension('framework', array(
+    'templating' => array(
+        'engines' => array('php', 'twig'),
+    ),
+));

Tests/DependencyInjection/Fixtures/php/templating_php_assets_disabled.php

@@ -0,0 +1,8 @@
+<?php
+
+$container->loadFromExtension('framework', array(
+    'assets' => false,
+    'templating' => array(
+        'engines' => array('php'),
+    ),
+));

Tests/DependencyInjection/Fixtures/xml/templating_no_assets.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" ?>
+<container xmlns="http://symfony.com/schema/dic/services"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns:framework="http://symfony.com/schema/dic/symfony"
+    xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
+        http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd">
+
+    <framework:config>
+        <framework:templating>
+            <framework:engine>php</framework:engine>
+            <framework:engine>twig</framework:engine>
+        </framework:templating>
+    </framework:config>
+</container>

Tests/DependencyInjection/Fixtures/yml/templating_no_assets.yml

@@ -0,0 +1,3 @@
+framework:
+    templating:
+        engines: [php, twig]

Tests/DependencyInjection/Fixtures/yml/templating_php_assets_disabled.yml

@@ -0,0 +1,4 @@
+framework:
+    assets: false
+    templating:
+        engines: [php]

Tests/DependencyInjection/FrameworkExtensionTest.php

@@ -436,14 +436,21 @@ public function testAssetHelperWhenAssetsAreEnabled()
         $this->assertSame('assets.packages', (string) $packages);
     }
 
-    public function testAssetHelperWhenTemplatesAreEnabledAndAssetsAreDisabled()
+    public function testAssetHelperWhenTemplatesAreEnabledAndNoAssetsConfiguration()
     {
-        $container = $this->createContainerFromFile('full');
+        $container = $this->createContainerFromFile('templating_no_assets');
         $packages = $container->getDefinition('templating.helper.assets')->getArgument(0);
 
         $this->assertSame('assets.packages', (string) $packages);
     }
 
+    public function testAssetsHelperIsRemovedWhenPhpTemplatingEngineIsEnabledAndAssetsAreDisabled()
+    {
+        $container = $this->createContainerFromFile('templating_php_assets_disabled');
+
+        $this->assertTrue(!$container->has('templating.helper.assets'), 'The templating.helper.assets helper service is removed when assets are disabled.');
+    }
+
     public function testAssetHelperWhenAssetsAndTemplatesAreDisabled()
     {
         $container = $this->createContainerFromFile('default_config');

Tests/DependencyInjection/XmlFrameworkExtensionTest.php

@@ -22,4 +22,9 @@ protected function loadFromFile(ContainerBuilder $container, $file)
         $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/Fixtures/xml'));
         $loader->load($file.'.xml');
     }
+
+    public function testAssetsHelperIsRemovedWhenPhpTemplatingEngineIsEnabledAndAssetsAreDisabled()
+    {
+        $this->markTestSkipped('The assets key cannot be set to false using the XML configuration format.');
+    }
 }