fixes

Author: nicolas-grekas

Tests/DependencyInjection/Compiler/AddExpressionLanguageProvidersPassTest.php

@@ -26,9 +26,9 @@ public function testProcessForRouter()
 
         $definition = new Definition('Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\TestProvider');
         $definition->addTag('routing.expression_language_provider');
-        $container->setDefinition('some_routing_provider', $definition);
+        $container->setDefinition('some_routing_provider', $definition->setPublic(true));
 
-        $container->register('router', '\stdClass');
+        $container->register('router', '\stdClass')->setPublic(true);
         $container->compile();
 
         $router = $container->getDefinition('router');
@@ -45,9 +45,9 @@ public function testProcessForRouterAlias()
 
         $definition = new Definition('Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\TestProvider');
         $definition->addTag('routing.expression_language_provider');
-        $container->setDefinition('some_routing_provider', $definition);
+        $container->setDefinition('some_routing_provider', $definition->setPublic(true));
 
-        $container->register('my_router', '\stdClass');
+        $container->register('my_router', '\stdClass')->setPublic(true);
         $container->setAlias('router', 'my_router');
         $container->compile();
 
@@ -65,9 +65,9 @@ public function testProcessForSecurity()
 
         $definition = new Definition('Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\TestProvider');
         $definition->addTag('security.expression_language_provider');
-        $container->setDefinition('some_security_provider', $definition);
+        $container->setDefinition('some_security_provider', $definition->setPublic(true));
 
-        $container->register('security.access.expression_voter', '\stdClass');
+        $container->register('security.access.expression_voter', '\stdClass')->setPublic(true);
         $container->compile();
 
         $router = $container->getDefinition('security.access.expression_voter');
@@ -84,9 +84,9 @@ public function testProcessForSecurityAlias()
 
         $definition = new Definition('Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\TestProvider');
         $definition->addTag('security.expression_language_provider');
-        $container->setDefinition('some_security_provider', $definition);
+        $container->setDefinition('some_security_provider', $definition->setPublic(true));
 
-        $container->register('my_security.access.expression_voter', '\stdClass');
+        $container->register('my_security.access.expression_voter', '\stdClass')->setPublic(true);
         $container->setAlias('security.access.expression_voter', 'my_security.access.expression_voter');
         $container->compile();
 

Tests/DependencyInjection/Compiler/FormPassTest.php

@@ -41,6 +41,7 @@ public function testAddTaggedTypes()
         $container->addCompilerPass(new FormPass());
 
         $extDefinition = new Definition('Symfony\Component\Form\Extension\DependencyInjection\DependencyInjectionExtension');
+        $extDefinition->setPublic(true);
         $extDefinition->setArguments(array(
             new Reference('service_container'),
             array(),
@@ -49,8 +50,8 @@ public function testAddTaggedTypes()
         ));
 
         $container->setDefinition('form.extension', $extDefinition);
-        $container->register('my.type1', __CLASS__.'_Type1')->addTag('form.type');
-        $container->register('my.type2', __CLASS__.'_Type2')->addTag('form.type');
+        $container->register('my.type1', __CLASS__.'_Type1')->addTag('form.type')->setPublic(true);
+        $container->register('my.type2', __CLASS__.'_Type2')->addTag('form.type')->setPublic(true);
 
         $container->compile();
 
@@ -76,6 +77,7 @@ public function testAddTaggedTypeExtensions(array $extensions, array $expectedRe
             array(),
             array(),
         ));
+        $extDefinition->setPublic(true);
 
         $container->setDefinition('form.extension', $extDefinition);
 
@@ -138,6 +140,7 @@ public function testAddTaggedFormTypeExtensionWithoutExtendedTypeAttribute()
             array(),
             array(),
         ));
+        $extDefinition->setPublic(true);
 
         $container->setDefinition('form.extension', $extDefinition);
         $container->register('my.type_extension', 'stdClass')
@@ -152,6 +155,7 @@ public function testAddTaggedGuessers()
         $container->addCompilerPass(new FormPass());
 
         $extDefinition = new Definition('Symfony\Component\Form\Extension\DependencyInjection\DependencyInjectionExtension');
+        $extDefinition->setPublic(true);
         $extDefinition->setArguments(array(
             new Reference('service_container'),
             array(),

Tests/Functional/app/CachePoolClear/config.yml

@@ -5,6 +5,7 @@ services:
     dummy:
         class: Symfony\Bundle\FrameworkBundle\Tests\Fixtures\DeclaredClass
         arguments: ['@cache.private_pool']
+        public: true
     custom_clearer:
         parent: cache.default_clearer
         tags: