[FrameworkBundle] Default to Apcu+Filesystem cache chain

Author: nicolas-grekas

DependencyInjection/Configuration.php

@@ -564,7 +564,7 @@ private function addCacheSection(ArrayNodeDefinition $rootNode)
                         ->end()
                         ->scalarNode('system')
                             ->info('System related cache pools configuration')
-                            ->defaultValue('cache.adapter.filesystem')
+                            ->defaultValue('cache.adapter.system')
                         ->end()
                         ->scalarNode('directory')->defaultValue('%kernel.cache_dir%/pools')->end()
                         ->scalarNode('default_doctrine_provider')->end()

DependencyInjection/FrameworkExtension.php

@@ -1039,6 +1039,7 @@ private function registerCacheConfiguration(array $config, ContainerBuilder $con
     {
         $nonce = substr(str_replace('/', '-', base64_encode(md5(uniqid(mt_rand(), true), true))), 0, -2);
         $container->getDefinition('cache.adapter.apcu')->replaceArgument(2, $nonce);
+        $container->getDefinition('cache.adapter.system')->replaceArgument(2, $nonce);
         $container->getDefinition('cache.adapter.filesystem')->replaceArgument(2, $config['directory']);
 
         foreach (array('doctrine', 'psr6', 'redis') as $name) {

Resources/config/cache.xml

@@ -10,7 +10,7 @@
             <tag name="cache.pool" />
         </service>
 
-        <service id="cache.system" parent="cache.adapter.filesystem">
+        <service id="cache.system" parent="cache.adapter.system">
             <tag name="cache.pool" />
         </service>
 
@@ -22,6 +22,17 @@
             <tag name="cache.pool" />
         </service>
 
+        <service id="cache.adapter.system" class="Symfony\Component\Cache\Adapter\AdapterInterface" abstract="true">
+            <factory class="Symfony\Component\Cache\Adapter\AbstractAdapter" method="createSystemCache" />
+            <tag name="cache.pool" clearer="cache.default_clearer" />
+            <tag name="monolog.logger" channel="cache" />
+            <argument /> <!-- namespace -->
+            <argument /> <!-- default lifetime -->
+            <argument /> <!-- nonce -->
+            <argument>%kernel.cache_dir%/pools</argument>
+            <argument type="service" id="logger" on-invalid="ignore" />
+        </service>
+
         <service id="cache.adapter.apcu" class="Symfony\Component\Cache\Adapter\ApcuAdapter" abstract="true">
             <tag name="cache.pool" clearer="cache.default_clearer" />
             <tag name="monolog.logger" channel="cache" />

Tests/DependencyInjection/ConfigurationTest.php

@@ -269,7 +269,7 @@ protected static function getBundleDefaultConfig()
             'cache' => array(
                 'pools' => array(),
                 'app' => 'cache.adapter.filesystem',
-                'system' => 'cache.adapter.filesystem',
+                'system' => 'cache.adapter.system',
                 'directory' => '%kernel.cache_dir%/pools',
                 'default_redis_provider' => 'redis://localhost',
             ),

Tests/DependencyInjection/FrameworkExtensionTest.php

@@ -14,6 +14,7 @@
 use Symfony\Bundle\FrameworkBundle\Tests\TestCase;
 use Symfony\Bundle\FrameworkBundle\DependencyInjection\FrameworkExtension;
 use Symfony\Component\Cache\Adapter\ApcuAdapter;
+use Symfony\Component\Cache\Adapter\ChainAdapter;
 use Symfony\Component\Cache\Adapter\DoctrineAdapter;
 use Symfony\Component\Cache\Adapter\FilesystemAdapter;
 use Symfony\Component\Cache\Adapter\ProxyAdapter;
@@ -728,6 +729,9 @@ private function assertCachePoolServiceDefinitionIsCreated(ContainerBuilder $con
                 $this->assertSame(DoctrineAdapter::class, $parentDefinition->getClass());
                 break;
             case 'cache.app':
+                if (ChainAdapter::class === $parentDefinition->getClass()) {
+                    break;
+                }
             case 'cache.adapter.filesystem':
                 $this->assertSame(FilesystemAdapter::class, $parentDefinition->getClass());
                 break;

composer.json

@@ -58,6 +58,7 @@
         "phpdocumentor/reflection-docblock": "<3.0"
     },
     "suggest": {
+        "ext-apcu": "For best performance of the system caches",
         "symfony/console": "For using the console commands",
         "symfony/form": "For using forms",
         "symfony/serializer": "For using the serializer service",