tweak the factory class description for inlined factory services

xabbuh · xabbuh · commit 573c5629800d · 2022-09-02T15:59:00.000+02:00
diff --git a/Console/Descriptor/JsonDescriptor.php b/Console/Descriptor/JsonDescriptor.php
@@ -219,7 +219,7 @@ private function getContainerDefinitionData(Definition $definition, bool $omitTa
                 if ($factory[0] instanceof Reference) {
                     $data['factory_service'] = (string) $factory[0];
                 } elseif ($factory[0] instanceof Definition) {
-                    $data['factory_class'] = $factory[0]->getClass() ?? 'not configured';
+                    $data['factory_service'] = sprintf('inline factory service (%s)', $factory[0]->getClass() ?? 'class not configured');
                 } else {
                     $data['factory_class'] = $factory[0];
                 }
diff --git a/Console/Descriptor/MarkdownDescriptor.php b/Console/Descriptor/MarkdownDescriptor.php
@@ -196,7 +196,7 @@ protected function describeContainerDefinition(Definition $definition, array $op
                 if ($factory[0] instanceof Reference) {
                     $output .= "\n".'- Factory Service: `'.$factory[0].'`';
                 } elseif ($factory[0] instanceof Definition) {
-                    $output .= "\n".'- Factory Class: `'.($factory[0]->getClass() ?? 'not configured').'`';
+                    $output .= "\n".sprintf('- Factory Service: inline factory service (%s)', $factory[0]->getClass() ? sprintf('`%s`', $factory[0]->getClass()) : 'not configured');
                 } else {
                     $output .= "\n".'- Factory Class: `'.$factory[0].'`';
                 }
diff --git a/Console/Descriptor/TextDescriptor.php b/Console/Descriptor/TextDescriptor.php
@@ -309,7 +309,7 @@ protected function describeContainerDefinition(Definition $definition, array $op
                 if ($factory[0] instanceof Reference) {
                     $tableRows[] = ['Factory Service', $factory[0]];
                 } elseif ($factory[0] instanceof Definition) {
-                    $tableRows[] = ['Factory Class', $factory[0]->getClass() ?? 'not configured'];
+                    $tableRows[] = ['Factory Service', sprintf('inline factory service (%s)', $factory[0]->getClass() ?? 'class not configured')];
                 } else {
                     $tableRows[] = ['Factory Class', $factory[0]];
                 }
diff --git a/Console/Descriptor/XmlDescriptor.php b/Console/Descriptor/XmlDescriptor.php
@@ -294,7 +294,7 @@ private function getContainerDefinitionDocument(Definition $definition, string $
                 if ($factory[0] instanceof Reference) {
                     $factoryXML->setAttribute('service', (string) $factory[0]);
                 } elseif ($factory[0] instanceof Definition) {
-                    $factoryXML->setAttribute('class', $factory[0]->getClass() ?? 'not configured');
+                    $factoryXML->setAttribute('service', sprintf('inline factory service (%s)', $factory[0]->getClass() ?? 'not configured'));
                 } else {
                     $factoryXML->setAttribute('class', $factory[0]);
                 }
diff --git a/Tests/Fixtures/Descriptor/builder_1_services.json b/Tests/Fixtures/Descriptor/builder_1_services.json
@@ -45,7 +45,7 @@
             "autowire": false,
             "autoconfigure": false,
             "file": "\/path\/to\/file",
-            "factory_class": "Full\\Qualified\\FactoryClass",
+            "factory_service": "inline factory service (Full\\Qualified\\FactoryClass)",
             "factory_method": "get",
             "tags": []
         }
diff --git a/Tests/Fixtures/Descriptor/builder_1_services.md b/Tests/Fixtures/Descriptor/builder_1_services.md
@@ -36,7 +36,7 @@ Definitions
 - Autowired: no
 - Autoconfigured: no
 - File: `/path/to/file`
-- Factory Class: `Full\Qualified\FactoryClass`
+- Factory Service: inline factory service (`Full\Qualified\FactoryClass`)
 - Factory Method: `get`
 
 
diff --git a/Tests/Fixtures/Descriptor/builder_1_services.xml b/Tests/Fixtures/Descriptor/builder_1_services.xml
@@ -18,6 +18,6 @@
     </tags>
   </definition>
   <definition id=".definition_3" class="Full\Qualified\Class3" public="false" synthetic="false" lazy="false" shared="true" abstract="false" autowired="false" autoconfigured="false" file="/path/to/file">
-    <factory class="Full\Qualified\FactoryClass" method="get"/>
+    <factory service="inline factory service (Full\Qualified\FactoryClass)" method="get"/>
   </definition>
 </container>
diff --git a/Tests/Fixtures/Descriptor/definition_3.json b/Tests/Fixtures/Descriptor/definition_3.json
@@ -8,7 +8,7 @@
     "autowire": false,
     "autoconfigure": false,
     "file": "\/path\/to\/file",
-    "factory_class": "Full\\Qualified\\FactoryClass",
+    "factory_service": "inline factory service (Full\\Qualified\\FactoryClass)",
     "factory_method": "get",
     "tags": []
 }
diff --git a/Tests/Fixtures/Descriptor/definition_3.md b/Tests/Fixtures/Descriptor/definition_3.md
@@ -7,5 +7,5 @@
 - Autowired: no
 - Autoconfigured: no
 - File: `/path/to/file`
-- Factory Class: `Full\Qualified\FactoryClass`
+- Factory Service: inline factory service (`Full\Qualified\FactoryClass`)
 - Factory Method: `get`
diff --git a/Tests/Fixtures/Descriptor/definition_3.txt b/Tests/Fixtures/Descriptor/definition_3.txt
@@ -1,18 +1,18 @@
- ---------------- ----------------------------- 
- [32m Option         [39m [32m Value                       [39m 
- ---------------- ----------------------------- 
-  Service ID       -                            
-  Class            Full\Qualified\Class3        
-  Tags             -                            
-  Public           no                           
-  Synthetic        no                           
-  Lazy             no                           
-  Shared           yes                          
-  Abstract         no                           
-  Autowired        no                           
-  Autoconfigured   no                           
-  Required File    /path/to/file                
-  Factory Class    Full\Qualified\FactoryClass  
-  Factory Method   get                          
- ---------------- ----------------------------- 
+ ----------------- ------------------------------------------------------ 
+ [32m Option          [39m [32m Value                                                [39m 
+ ----------------- ------------------------------------------------------ 
+  Service ID        -                                                     
+  Class             Full\Qualified\Class3                                 
+  Tags              -                                                     
+  Public            no                                                    
+  Synthetic         no                                                    
+  Lazy              no                                                    
+  Shared            yes                                                   
+  Abstract          no                                                    
+  Autowired         no                                                    
+  Autoconfigured    no                                                    
+  Required File     /path/to/file                                         
+  Factory Service   inline factory service (Full\Qualified\FactoryClass)  
+  Factory Method    get                                                   
+ ----------------- ------------------------------------------------------ 
 
diff --git a/Tests/Fixtures/Descriptor/definition_3.xml b/Tests/Fixtures/Descriptor/definition_3.xml
@@ -1,4 +1,4 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <definition class="Full\Qualified\Class3" public="false" synthetic="false" lazy="false" shared="true" abstract="false" autowired="false" autoconfigured="false" file="/path/to/file">
-  <factory class="Full\Qualified\FactoryClass" method="get"/>
+  <factory service="inline factory service (Full\Qualified\FactoryClass)" method="get"/>
 </definition>
diff --git a/Tests/Fixtures/Descriptor/definition_arguments_3.json b/Tests/Fixtures/Descriptor/definition_arguments_3.json
@@ -9,7 +9,7 @@
     "autoconfigure": false,
     "arguments": [],
     "file": "\/path\/to\/file",
-    "factory_class": "Full\\Qualified\\FactoryClass",
+    "factory_service": "inline factory service (Full\\Qualified\\FactoryClass)",
     "factory_method": "get",
     "tags": []
 }
diff --git a/Tests/Fixtures/Descriptor/definition_arguments_3.md b/Tests/Fixtures/Descriptor/definition_arguments_3.md
@@ -8,5 +8,5 @@
 - Autoconfigured: no
 - Arguments: no
 - File: `/path/to/file`
-- Factory Class: `Full\Qualified\FactoryClass`
+- Factory Service: inline factory service (`Full\Qualified\FactoryClass`)
 - Factory Method: `get`
diff --git a/Tests/Fixtures/Descriptor/definition_arguments_3.txt b/Tests/Fixtures/Descriptor/definition_arguments_3.txt
@@ -1,18 +1,18 @@
- ---------------- ----------------------------- 
- [32m Option         [39m [32m Value                       [39m 
- ---------------- ----------------------------- 
-  Service ID       -                            
-  Class            Full\Qualified\Class3        
-  Tags             -                            
-  Public           no                           
-  Synthetic        no                           
-  Lazy             no                           
-  Shared           yes                          
-  Abstract         no                           
-  Autowired        no                           
-  Autoconfigured   no                           
-  Required File    /path/to/file                
-  Factory Class    Full\Qualified\FactoryClass  
-  Factory Method   get                          
- ---------------- -----------------------------
+ ----------------- ------------------------------------------------------ 
+ [32m Option          [39m [32m Value                                                [39m 
+ ----------------- ------------------------------------------------------ 
+  Service ID        -                                                     
+  Class             Full\Qualified\Class3                                 
+  Tags              -                                                     
+  Public            no                                                    
+  Synthetic         no                                                    
+  Lazy              no                                                    
+  Shared            yes                                                   
+  Abstract          no                                                    
+  Autowired         no                                                    
+  Autoconfigured    no                                                    
+  Required File     /path/to/file                                         
+  Factory Service   inline factory service (Full\Qualified\FactoryClass)  
+  Factory Method    get                                                   
+ ----------------- ------------------------------------------------------
 
diff --git a/Tests/Fixtures/Descriptor/definition_arguments_3.xml b/Tests/Fixtures/Descriptor/definition_arguments_3.xml
@@ -1,4 +1,4 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <definition class="Full\Qualified\Class3" public="false" synthetic="false" lazy="false" shared="true" abstract="false" autowired="false" autoconfigured="false" file="/path/to/file">
-  <factory class="Full\Qualified\FactoryClass" method="get"/>
+  <factory service="inline factory service (Full\Qualified\FactoryClass)" method="get"/>
 </definition>

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ private function getContainerDefinitionData(Definition $definition, bool $omitTa`
`219`	`219`	`if ($factory[0] instanceof Reference) {`
`220`	`220`	`$data['factory_service'] = (string) $factory[0];`
`221`	`221`	`} elseif ($factory[0] instanceof Definition) {`
`222`		`- $data['factory_class'] = $factory[0]->getClass() ?? 'not configured';`
	`222`	`+ $data['factory_service'] = sprintf('inline factory service (%s)', $factory[0]->getClass() ?? 'class not configured');`
`223`	`223`	`} else {`
`224`	`224`	`$data['factory_class'] = $factory[0];`
`225`	`225`	`}`
Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ protected function describeContainerDefinition(Definition $definition, array $op`
`196`	`196`	`if ($factory[0] instanceof Reference) {`
`197`	`197`	$output .= "\n".'- Factory Service: `'.$factory[0].'`';
`198`	`198`	`} elseif ($factory[0] instanceof Definition) {`
`199`		- $output .= "\n".'- Factory Class: `'.($factory[0]->getClass() ?? 'not configured').'`';
	`199`	+ $output .= "\n".sprintf('- Factory Service: inline factory service (%s)', $factory[0]->getClass() ? sprintf('`%s`', $factory[0]->getClass()) : 'not configured');
`200`	`200`	`} else {`
`201`	`201`	$output .= "\n".'- Factory Class: `'.$factory[0].'`';
`202`	`202`	`}`
Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,7 @@ protected function describeContainerDefinition(Definition $definition, array $op`
`309`	`309`	`if ($factory[0] instanceof Reference) {`
`310`	`310`	`$tableRows[] = ['Factory Service', $factory[0]];`
`311`	`311`	`} elseif ($factory[0] instanceof Definition) {`
`312`		`- $tableRows[] = ['Factory Class', $factory[0]->getClass() ?? 'not configured'];`
	`312`	`+ $tableRows[] = ['Factory Service', sprintf('inline factory service (%s)', $factory[0]->getClass() ?? 'class not configured')];`
`313`	`313`	`} else {`
`314`	`314`	`$tableRows[] = ['Factory Class', $factory[0]];`
`315`	`315`	`}`
Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ private function getContainerDefinitionDocument(Definition $definition, string $`
`294`	`294`	`if ($factory[0] instanceof Reference) {`
`295`	`295`	`$factoryXML->setAttribute('service', (string) $factory[0]);`
`296`	`296`	`} elseif ($factory[0] instanceof Definition) {`
`297`		`- $factoryXML->setAttribute('class', $factory[0]->getClass() ?? 'not configured');`
	`297`	`+ $factoryXML->setAttribute('service', sprintf('inline factory service (%s)', $factory[0]->getClass() ?? 'not configured'));`
`298`	`298`	`} else {`
`299`	`299`	`$factoryXML->setAttribute('class', $factory[0]);`
`300`	`300`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@`
`45`	`45`	`"autowire": false,`
`46`	`46`	`"autoconfigure": false,`
`47`	`47`	`"file": "\/path\/to\/file",`
`48`		`- "factory_class": "Full\\Qualified\\FactoryClass",`
	`48`	`+ "factory_service": "inline factory service (Full\\Qualified\\FactoryClass)",`
`49`	`49`	`"factory_method": "get",`
`50`	`50`	`"tags": []`
`51`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`"autowire": false,`
`9`	`9`	`"autoconfigure": false,`
`10`	`10`	`"file": "\/path\/to\/file",`
`11`		`- "factory_class": "Full\\Qualified\\FactoryClass",`
	`11`	`+ "factory_service": "inline factory service (Full\\Qualified\\FactoryClass)",`
`12`	`12`	`"factory_method": "get",`
`13`	`13`	`"tags": []`
`14`	`14`	`}`