Use createMock() instead of a getter

OskarStark · chalasr · commit 41094d6d60a0 · 2021-01-28T20:07:50.000+01:00
diff --git a/Tests/Templating/TimedPhpEngineTest.php b/Tests/Templating/TimedPhpEngineTest.php
@@ -29,7 +29,7 @@ class TimedPhpEngineTest extends TestCase
 {
     public function testThatRenderLogsTime()
     {
-        $container = $this->getContainer();
+        $container = $this->createMock(Container::class);
         $templateNameParser = $this->getTemplateNameParser();
         $globalVariables = $this->getGlobalVariables();
         $loader = $this->getLoader($this->getStorage());
@@ -48,11 +48,6 @@ public function testThatRenderLogsTime()
         $engine->render('index.php');
     }
 
-    private function getContainer(): Container
-    {
-        return $this->createMock(Container::class);
-    }
-
     private function getTemplateNameParser(): TemplateNameParserInterface
     {
         $templateReference = $this->createMock(TemplateReferenceInterface::class);

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class TimedPhpEngineTest extends TestCase`
`29`	`29`	`{`
`30`	`30`	`public function testThatRenderLogsTime()`
`31`	`31`	`{`
`32`		`- $container = $this->getContainer();`
	`32`	`+ $container = $this->createMock(Container::class);`
`33`	`33`	`$templateNameParser = $this->getTemplateNameParser();`
`34`	`34`	`$globalVariables = $this->getGlobalVariables();`
`35`	`35`	`$loader = $this->getLoader($this->getStorage());`
`@@ -48,11 +48,6 @@ public function testThatRenderLogsTime()`
`48`	`48`	`$engine->render('index.php');`
`49`	`49`	`}`
`50`	`50`
`51`		`- private function getContainer(): Container`
`52`		`- {`
`53`		`- return $this->createMock(Container::class);`
`54`		`- }`
`55`		`-`
`56`	`51`	`private function getTemplateNameParser(): TemplateNameParserInterface`
`57`	`52`	`{`
`58`	`53`	`$templateReference = $this->createMock(TemplateReferenceInterface::class);`