[DI] compute autowiring error messages lazily

nicolas-grekas · nicolas-grekas · commit 2f3929aad3ba · 2018-11-06T20:03:07.000+01:00
diff --git a/DependencyInjection/Compiler/TestServiceContainerWeakRefPass.php b/DependencyInjection/Compiler/TestServiceContainerWeakRefPass.php
@@ -31,7 +31,7 @@ public function process(ContainerBuilder $container)
         $definitions = $container->getDefinitions();
 
         foreach ($definitions as $id => $definition) {
-            if ($id && '.' !== $id[0] && (!$definition->isPublic() || $definition->isPrivate()) && !$definition->getErrors() && !$definition->isAbstract()) {
+            if ($id && '.' !== $id[0] && (!$definition->isPublic() || $definition->isPrivate()) && !$definition->hasErrors() && !$definition->isAbstract()) {
                 $privateServices[$id] = new Reference($id, ContainerBuilder::IGNORE_ON_UNINITIALIZED_REFERENCE);
             }
         }
@@ -43,7 +43,7 @@ public function process(ContainerBuilder $container)
                 while (isset($aliases[$target = (string) $alias])) {
                     $alias = $aliases[$target];
                 }
-                if (isset($definitions[$target]) && !$definitions[$target]->getErrors() && !$definitions[$target]->isAbstract()) {
+                if (isset($definitions[$target]) && !$definitions[$target]->hasErrors() && !$definitions[$target]->isAbstract()) {
                     $privateServices[$id] = new Reference($target, ContainerBuilder::IGNORE_ON_UNINITIALIZED_REFERENCE);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function process(ContainerBuilder $container)`
`31`	`31`	`$definitions = $container->getDefinitions();`
`32`	`32`
`33`	`33`	`foreach ($definitions as $id => $definition) {`
`34`		`- if ($id && '.' !== $id[0] && (!$definition->isPublic() \|\| $definition->isPrivate()) && !$definition->getErrors() && !$definition->isAbstract()) {`
	`34`	`+ if ($id && '.' !== $id[0] && (!$definition->isPublic() \|\| $definition->isPrivate()) && !$definition->hasErrors() && !$definition->isAbstract()) {`
`35`	`35`	`$privateServices[$id] = new Reference($id, ContainerBuilder::IGNORE_ON_UNINITIALIZED_REFERENCE);`
`36`	`36`	`}`
`37`	`37`	`}`
`@@ -43,7 +43,7 @@ public function process(ContainerBuilder $container)`
`43`	`43`	`while (isset($aliases[$target = (string) $alias])) {`
`44`	`44`	`$alias = $aliases[$target];`
`45`	`45`	`}`
`46`		`- if (isset($definitions[$target]) && !$definitions[$target]->getErrors() && !$definitions[$target]->isAbstract()) {`
	`46`	`+ if (isset($definitions[$target]) && !$definitions[$target]->hasErrors() && !$definitions[$target]->isAbstract()) {`
`47`	`47`	`$privateServices[$id] = new Reference($target, ContainerBuilder::IGNORE_ON_UNINITIALIZED_REFERENCE);`
`48`	`48`	`}`
`49`	`49`	`}`