minor #37212 [FrameworkBundle] Move debug configuration to PHP (Benoit Mallo)

This PR was squashed before being merged into the 5.2-dev branch.

Discussion
----------

[FrameworkBundle] Move debug configuration to PHP

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Ref #37186
| License       | MIT
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

a226a52d65 [FrameworkBundle] Move debug configuration to PHP

Author: fabpot

DependencyInjection/FrameworkExtension.php

@@ -371,7 +371,7 @@ public function load(array $configs, ContainerBuilder $container)
         $this->registerTranslatorConfiguration($config['translator'], $container, $loader, $config['default_locale']);
         $this->registerProfilerConfiguration($config['profiler'], $container, $loader);
         $this->registerWorkflowConfiguration($config['workflows'], $container, $loader);
-        $this->registerDebugConfiguration($config['php_errors'], $container, $loader);
+        $this->registerDebugConfiguration($config['php_errors'], $container, $phpLoader);
         $this->registerRouterConfiguration($config['router'], $container, $loader, $config['translator']['enabled_locales'] ?? []);
         $this->registerAnnotationsConfiguration($config['annotations'], $container, $loader);
         $this->registerPropertyAccessConfiguration($config['property_access'], $container, $loader);
@@ -821,9 +821,9 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
         }
     }
 
-    private function registerDebugConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
+    private function registerDebugConfiguration(array $config, ContainerBuilder $container, PhpFileLoader $loader)
     {
-        $loader->load('debug_prod.xml');
+        $loader->load('debug_prod.php');
 
         if (class_exists(Stopwatch::class)) {
             $container->register('debug.stopwatch', Stopwatch::class)
@@ -840,7 +840,7 @@ private function registerDebugConfiguration(array $config, ContainerBuilder $con
         }
 
         if ($debug && class_exists(Stopwatch::class)) {
-            $loader->load('debug.xml');
+            $loader->load('debug.php');
         }
 
         $definition = $container->findDefinition('debug.debug_handlers_listener');

Resources/config/debug.php

@@ -0,0 +1,50 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use Symfony\Component\HttpKernel\Controller\ArgumentResolver\NotTaggedControllerValueResolver;
+use Symfony\Component\HttpKernel\Controller\TraceableArgumentResolver;
+use Symfony\Component\HttpKernel\Controller\TraceableControllerResolver;
+use Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher;
+
+return static function (ContainerConfigurator $container) {
+    $container->services()
+        ->set('debug.event_dispatcher', TraceableEventDispatcher::class)
+            ->decorate('event_dispatcher')
+            ->args([
+                service('debug.event_dispatcher.inner'),
+                service('debug.stopwatch'),
+                service('logger')->nullOnInvalid(),
+                service('request_stack')->nullOnInvalid(),
+            ])
+            ->tag('monolog.logger', ['channel' => 'event'])
+            ->tag('kernel.reset', ['method' => 'reset'])
+
+        ->set('debug.controller_resolver', TraceableControllerResolver::class)
+            ->decorate('controller_resolver')
+            ->args([
+                service('debug.controller_resolver.inner'),
+                service('debug.stopwatch'),
+            ])
+
+        ->set('debug.argument_resolver', TraceableArgumentResolver::class)
+            ->decorate('argument_resolver')
+            ->args([
+                service('debug.argument_resolver.inner'),
+                service('debug.stopwatch'),
+            ])
+
+        ->set('argument_resolver.not_tagged_controller', NotTaggedControllerValueResolver::class)
+            ->args([abstract_arg('Controller argument, set in FrameworkExtension')])
+            ->tag('controller.argument_value_resolver', ['priority' => -200])
+    ;
+};

Resources/config/debug.xml

@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use Symfony\Component\HttpKernel\Debug\FileLinkFormatter;
+use Symfony\Component\HttpKernel\EventListener\DebugHandlersListener;
+
+return static function (ContainerConfigurator $container) {
+    $container->parameters()->set('debug.error_handler.throw_at', -1);
+
+    $container->services()
+        ->set('debug.debug_handlers_listener', DebugHandlersListener::class)
+            ->args([
+                null, // Exception handler
+                service('monolog.logger.php')->nullOnInvalid(),
+                null, // Log levels map for enabled error levels
+                param('debug.error_handler.throw_at'),
+                param('kernel.debug'),
+                service('debug.file_link_formatter'),
+                param('kernel.debug'),
+                service('monolog.logger.deprecation')->nullOnInvalid(),
+            ])
+            ->tag('kernel.event_subscriber')
+            ->tag('monolog.logger', ['channel' => 'php'])
+
+        ->set('debug.file_link_formatter', FileLinkFormatter::class)
+            ->args([param('debug.file_link_format')])
+
+        ->alias(FileLinkFormatter::class, 'debug.file_link_formatter')
+    ;
+};