(finally) fix version dependent Form tests

Author: xabbuh

Tests/AbstractLayoutTest.php

@@ -2589,6 +2589,90 @@ public function testColor()
     [@type="color"]
     [@name="name"]
     [@value="#0000ff"]
+'
+        );
+    }
+
+    public function testLabelWithTranslationParameters()
+    {
+        $this->requiresFeatureSet(403);
+
+        $form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\TextType');
+        $html = $this->renderLabel($form->createView(), 'Address is %address%', [
+            'label_translation_parameters' => [
+                '%address%' => 'Paris, rue de la Paix',
+            ],
+        ]);
+
+        $this->assertMatchesXpath($html,
+            '/label
+    [@for="name"]
+    [.="[trans]Address is Paris, rue de la Paix[/trans]"]
+'
+        );
+    }
+
+    public function testHelpWithTranslationParameters()
+    {
+        $this->requiresFeatureSet(403);
+
+        $form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\TextType', null, [
+            'help' => 'for company %company%',
+            'help_translation_parameters' => [
+                '%company%' => 'ACME Ltd.',
+            ],
+        ]);
+        $html = $this->renderHelp($form->createView());
+
+        $this->assertMatchesXpath($html,
+            '/*
+    [@id="name_help"]
+    [.="[trans]for company ACME Ltd.[/trans]"]
+'
+        );
+    }
+
+    public function testAttributesWithTranslationParameters()
+    {
+        $this->requiresFeatureSet(403);
+
+        $form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\TextType', null, [
+            'attr' => [
+                'title' => 'Message to %company%',
+                'placeholder' => 'Enter a message to %company%',
+            ],
+            'attr_translation_parameters' => [
+                '%company%' => 'ACME Ltd.',
+            ],
+        ]);
+        $html = $this->renderWidget($form->createView());
+
+        $this->assertMatchesXpath($html,
+            '/input
+    [@title="[trans]Message to ACME Ltd.[/trans]"]
+    [@placeholder="[trans]Enter a message to ACME Ltd.[/trans]"]
+'
+        );
+    }
+
+    public function testButtonWithTranslationParameters()
+    {
+        $this->requiresFeatureSet(403);
+
+        $form = $this->factory->createNamedBuilder('myform')
+            ->add('mybutton', 'Symfony\Component\Form\Extension\Core\Type\ButtonType', [
+                'label' => 'Submit to %company%',
+                'label_translation_parameters' => [
+                    '%company%' => 'ACME Ltd.',
+                ],
+            ])
+            ->getForm();
+        $view = $form->get('mybutton')->createView();
+        $html = $this->renderWidget($view, ['label_format' => 'form.%name%']);
+
+        $this->assertMatchesXpath($html,
+            '/button
+    [.="[trans]Submit to ACME Ltd.[/trans]"]
 '
         );
     }

Tests/Extension/Core/Type/BaseTypeTest.php

@@ -124,6 +124,8 @@ public function testDefaultTranslationDomain()
 
     public function testPassLabelTranslationParametersToView()
     {
+        $this->requiresFeatureSet(403);
+
         $view = $this->factory->create($this->getTestedType(), null, [
             'label_translation_parameters' => ['%param%' => 'value'],
         ])
@@ -134,6 +136,8 @@ public function testPassLabelTranslationParametersToView()
 
     public function testPassAttrTranslationParametersToView()
     {
+        $this->requiresFeatureSet(403);
+
         $view = $this->factory->create($this->getTestedType(), null, [
             'attr_translation_parameters' => ['%param%' => 'value'],
         ])
@@ -144,6 +148,8 @@ public function testPassAttrTranslationParametersToView()
 
     public function testInheritLabelTranslationParametersFromParent()
     {
+        $this->requiresFeatureSet(403);
+
         $view = $this->factory
             ->createNamedBuilder('parent', FormTypeTest::TESTED_TYPE, null, [
                 'label_translation_parameters' => ['%param%' => 'value'],
@@ -157,6 +163,8 @@ public function testInheritLabelTranslationParametersFromParent()
 
     public function testInheritAttrTranslationParametersFromParent()
     {
+        $this->requiresFeatureSet(403);
+
         $view = $this->factory
             ->createNamedBuilder('parent', FormTypeTest::TESTED_TYPE, null, [
                 'attr_translation_parameters' => ['%param%' => 'value'],
@@ -170,6 +178,8 @@ public function testInheritAttrTranslationParametersFromParent()
 
     public function testPreferOwnLabelTranslationParameters()
     {
+        $this->requiresFeatureSet(403);
+
         $view = $this->factory
             ->createNamedBuilder('parent', FormTypeTest::TESTED_TYPE, null, [
                 'label_translation_parameters' => ['%parent_param%' => 'parent_value', '%override_param%' => 'parent_override_value'],
@@ -185,6 +195,8 @@ public function testPreferOwnLabelTranslationParameters()
 
     public function testPreferOwnAttrTranslationParameters()
     {
+        $this->requiresFeatureSet(403);
+
         $view = $this->factory
             ->createNamedBuilder('parent', FormTypeTest::TESTED_TYPE, null, [
                 'attr_translation_parameters' => ['%parent_param%' => 'parent_value', '%override_param%' => 'parent_override_value'],
@@ -200,6 +212,8 @@ public function testPreferOwnAttrTranslationParameters()
 
     public function testDefaultLabelTranslationParameters()
     {
+        $this->requiresFeatureSet(403);
+
         $view = $this->factory->createNamedBuilder('parent', FormTypeTest::TESTED_TYPE)
             ->add('child', $this->getTestedType())
             ->getForm()
@@ -210,6 +224,8 @@ public function testDefaultLabelTranslationParameters()
 
     public function testDefaultAttrTranslationParameters()
     {
+        $this->requiresFeatureSet(403);
+
         $view = $this->factory->createNamedBuilder('parent', FormTypeTest::TESTED_TYPE)
             ->add('child', $this->getTestedType())
             ->getForm()