fix a return type hint

Author: xabbuh

FormBuilder.php

@@ -235,9 +235,9 @@ public function getIterator()
     }
 
     /**
-     * Converts an unresolved child into a {@link FormBuilder} instance.
+     * Converts an unresolved child into a {@link FormBuilderInterface} instance.
      */
-    private function resolveChild(string $name): self
+    private function resolveChild(string $name): FormBuilderInterface
     {
         $info = $this->unresolvedChildren[$name];
         $child = $this->create($name, $info['type'], $info['options']);

Tests/FormBuilderTest.php

@@ -13,7 +13,9 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Form\ButtonBuilder;
+use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\FormBuilder;
+use Symfony\Component\Form\FormFactoryBuilder;
 use Symfony\Component\Form\SubmitButtonBuilder;
 
 class FormBuilderTest extends TestCase
@@ -228,6 +230,14 @@ public function testGetFormConfigErasesReferences()
         $this->assertEmpty($unresolvedChildren->getValue($config));
     }
 
+    public function testGetButtonBuilderBeforeExplicitlyResolvingAllChildren()
+    {
+        $builder = new FormBuilder('name', null, $this->dispatcher, (new FormFactoryBuilder())->getFormFactory());
+        $builder->add('submit', SubmitType::class);
+
+        $this->assertInstanceOf(ButtonBuilder::class, $builder->get('submit'));
+    }
+
     private function getFormBuilder($name = 'name')
     {
         $mock = $this->getMockBuilder('Symfony\Component\Form\FormBuilder')