[tests] Use @requires annotation when possible

Author: nicolas-grekas

Tests/AbstractLayoutTest.php

@@ -22,7 +22,7 @@ abstract class AbstractLayoutTest extends \Symfony\Component\Form\Test\FormInteg
     protected function setUp()
     {
         if (!extension_loaded('intl')) {
-            $this->markTestSkipped('The "intl" extension is not available');
+            $this->markTestSkipped('Extension intl is required.');
         }
 
         \Locale::setDefault('en');

Tests/Extension/Core/DataTransformer/DateTimeToArrayTransformerTest.php

@@ -116,12 +116,11 @@ public function testTransformDifferentTimezones()
         $this->assertSame($output, $transformer->transform($input));
     }
 
+    /**
+     * @requires PHP 5.5
+     */
     public function testTransformDateTimeImmutable()
     {
-        if (PHP_VERSION_ID < 50500) {
-            $this->markTestSkipped('DateTimeImmutable was introduced in PHP 5.5.0');
-        }
-
         $transformer = new DateTimeToArrayTransformer('America/New_York', 'Asia/Hong_Kong');
 
         $input = new \DateTimeImmutable('2010-02-03 04:05:06 America/New_York');

Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php

@@ -141,12 +141,11 @@ public function testTransformWithDifferentPatterns()
         $this->assertEquals('02*2010*03 04|05|06', $transformer->transform($this->dateTime));
     }
 
+    /**
+     * @requires PHP 5.5
+     */
     public function testTransformDateTimeImmutableTimezones()
     {
-        if (PHP_VERSION_ID < 50500) {
-            $this->markTestSkipped('DateTimeImmutable was introduced in PHP 5.5.0');
-        }
-
         $transformer = new DateTimeToLocalizedStringTransformer('America/New_York', 'Asia/Hong_Kong');
 
         $input = new \DateTimeImmutable('2010-02-03 04:05:06 America/New_York');

Tests/Extension/Core/DataTransformer/DateTimeToRfc3339TransformerTest.php

@@ -81,13 +81,10 @@ public function testTransform($fromTz, $toTz, $from, $to)
 
     /**
      * @dataProvider transformProvider
+     * @requires PHP 5.5
      */
     public function testTransformDateTimeImmutable($fromTz, $toTz, $from, $to)
     {
-        if (PHP_VERSION_ID < 50500) {
-            $this->markTestSkipped('DateTimeImmutable was introduced in PHP 5.5.0');
-        }
-
         $transformer = new DateTimeToRfc3339Transformer($fromTz, $toTz);
 
         $this->assertSame($to, $transformer->transform(null !== $from ? new \DateTimeImmutable($from) : null));

Tests/Extension/Core/DataTransformer/DateTimeToStringTransformerTest.php

@@ -97,12 +97,11 @@ public function testTransformWithDifferentTimezones()
         $this->assertEquals($output, $transformer->transform($input));
     }
 
+    /**
+     * @requires PHP 5.5
+     */
     public function testTransformDateTimeImmutable()
     {
-        if (PHP_VERSION_ID < 50500) {
-            $this->markTestSkipped('DateTimeImmutable was introduced in PHP 5.5.0');
-        }
-
         $transformer = new DateTimeToStringTransformer('Asia/Hong_Kong', 'America/New_York', 'Y-m-d H:i:s');
 
         $input = new \DateTimeImmutable('2010-02-03 12:05:06 America/New_York');

Tests/Extension/Core/DataTransformer/DateTimeToTimestampTransformerTest.php

@@ -56,12 +56,11 @@ public function testTransformFromDifferentTimezone()
         $this->assertEquals($output, $transformer->transform($input));
     }
 
+    /**
+     * @requires PHP 5.5
+     */
     public function testTransformDateTimeImmutable()
     {
-        if (PHP_VERSION_ID < 50500) {
-            $this->markTestSkipped('DateTimeImmutable was introduced in PHP 5.5.0');
-        }
-
         $transformer = new DateTimeToTimestampTransformer('Asia/Hong_Kong', 'America/New_York');
 
         $input = new \DateTimeImmutable('2010-02-03 04:05:06 America/New_York');

Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php

@@ -134,13 +134,13 @@ public function testReverseTransformWithGrouping($to, $from, $locale)
         $this->assertEquals($to, $transformer->reverseTransform($from));
     }
 
-    // https://github.com/symfony/symfony/issues/7609
+    /**
+     * @see https://github.com/symfony/symfony/issues/7609
+     *
+     * @requires extension mbstring
+     */
     public function testReverseTransformWithGroupingAndFixedSpaces()
     {
-        if (!function_exists('mb_detect_encoding')) {
-            $this->markTestSkipped('The "mbstring" extension is required for this test.');
-        }
-
         // Since we test against other locales, we need the full implementation
         IntlTestHelper::requireFullIntl($this);
 
@@ -375,13 +375,10 @@ public function testReverseTransformDisallowsCenteredExtraCharacters()
     /**
      * @expectedException \Symfony\Component\Form\Exception\TransformationFailedException
      * @expectedExceptionMessage The number contains unrecognized characters: "foo8"
+     * @requires extension mbstring
      */
     public function testReverseTransformDisallowsCenteredExtraCharactersMultibyte()
     {
-        if (!function_exists('mb_detect_encoding')) {
-            $this->markTestSkipped('The "mbstring" extension is required for this test.');
-        }
-
         // Since we test against other locales, we need the full implementation
         IntlTestHelper::requireFullIntl($this);
 
@@ -395,13 +392,10 @@ public function testReverseTransformDisallowsCenteredExtraCharactersMultibyte()
     /**
      * @expectedException \Symfony\Component\Form\Exception\TransformationFailedException
      * @expectedExceptionMessage The number contains unrecognized characters: "foo8"
+     * @requires extension mbstring
      */
     public function testReverseTransformIgnoresTrailingSpacesInExceptionMessage()
     {
-        if (!function_exists('mb_detect_encoding')) {
-            $this->markTestSkipped('The "mbstring" extension is required for this test.');
-        }
-
         // Since we test against other locales, we need the full implementation
         IntlTestHelper::requireFullIntl($this);
 
@@ -426,13 +420,10 @@ public function testReverseTransformDisallowsTrailingExtraCharacters()
     /**
      * @expectedException \Symfony\Component\Form\Exception\TransformationFailedException
      * @expectedExceptionMessage The number contains unrecognized characters: "foo"
+     * @requires extension mbstring
      */
     public function testReverseTransformDisallowsTrailingExtraCharactersMultibyte()
     {
-        if (!function_exists('mb_detect_encoding')) {
-            $this->markTestSkipped('The "mbstring" extension is required for this test.');
-        }
-
         // Since we test against other locales, we need the full implementation
         IntlTestHelper::requireFullIntl($this);
 

Tests/Extension/Core/Type/DateTypeTest.php

@@ -873,8 +873,7 @@ public function testDayErrorsBubbleUp($widget)
     public function testYearsFor32BitsMachines()
     {
         if (4 !== PHP_INT_SIZE) {
-            $this->markTestSkipped(
-                'PHP must be compiled in 32 bit mode to run this test');
+            $this->markTestSkipped('PHP 32 bit is required.');
         }
 
         $form = $this->factory->create('date', null, array(

Tests/Extension/Csrf/CsrfProvider/DefaultCsrfProviderTest.php

@@ -47,14 +47,13 @@ public function testGenerateCsrfToken()
         $this->assertEquals(sha1('SECRET'.'foo'.session_id()), $token);
     }
 
+    /**
+     * @requires PHP 5.4
+     */
     public function testGenerateCsrfTokenOnUnstartedSession()
     {
         session_id('touti');
 
-        if (PHP_VERSION_ID < 50400) {
-            $this->markTestSkipped('This test requires PHP >= 5.4');
-        }
-
         $this->assertSame(PHP_SESSION_NONE, session_status());
 
         $token = $this->provider->generateCsrfToken('foo');