minor #17480 Static code analysis (Koc)

This PR was merged into the 2.3 branch.

Discussion
----------

Static code analysis

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Things that done:
* fix case in method calls
* removed unused imports
* use shorter concat where it possible
* optimize some css
* removed duplicated array keys
* removed redurant return statements
* removed one-time variables
* do not pass arguments that not used in functions

Commits
-------

8db691a Static code analysis

Author: fabpot

Extension/Core/Type/ChoiceType.php

@@ -71,10 +71,10 @@ public function buildForm(FormBuilderInterface $builder, array $options)
 
             if ($options['multiple']) {
                 $builder->addViewTransformer(new ChoicesToBooleanArrayTransformer($options['choice_list']));
-                $builder->addEventSubscriber(new FixCheckboxInputListener($options['choice_list']), 10);
+                $builder->addEventSubscriber(new FixCheckboxInputListener($options['choice_list']));
             } else {
                 $builder->addViewTransformer(new ChoiceToBooleanArrayTransformer($options['choice_list'], $builder->has('placeholder')));
-                $builder->addEventSubscriber(new FixRadioInputListener($options['choice_list'], $builder->has('placeholder')), 10);
+                $builder->addEventSubscriber(new FixRadioInputListener($options['choice_list'], $builder->has('placeholder')));
             }
         } else {
             if ($options['multiple']) {

Tests/Extension/Validator/Constraints/FormValidatorTest.php

@@ -569,11 +569,6 @@ public function getValidationGroups(FormInterface $form)
         return array('group1', 'group2');
     }
 
-    private function getMockExecutionContext()
-    {
-        return $this->getMock('Symfony\Component\Validator\ExecutionContextInterface');
-    }
-
     /**
      * @param string $name
      * @param string $dataClass

Tests/Extension/Validator/Type/BaseValidatorExtensionTest.php

@@ -64,7 +64,7 @@ public function testValidationGroupsCanBeSetToCallback()
     public function testValidationGroupsCanBeSetToClosure()
     {
         $form = $this->createForm(array(
-            'validation_groups' => function (FormInterface $form) { return; },
+            'validation_groups' => function (FormInterface $form) { },
         ));
 
         $this->assertTrue(is_callable($form->getConfig()->getOption('validation_groups')));

Tests/Util/OrderedHashMapTest.php

@@ -482,6 +482,6 @@ public function testCount()
         unset($map[0]);
         $map[] = 3;
 
-        $this->assertSame(2, count($map));
+        $this->assertCount(2, $map);
     }
 }