Merge branch '5.4' into 6.0

* 5.4:
  [Filesystem] Workaround cannot dumpFile into "protected" folders on Windows
  Handle concurency in Csrf DoctrineTokenProvider
  Missing translations for Chinese (zh_CN) #41814
  [VarDumper] improve support for AmpHttpClient
  update Italian translation
  Fix SessionTokenStorage reuse with Request
  added missing Arabic translations

Author: fabpot

Filesystem.php

@@ -651,10 +651,6 @@ public function dumpFile(string $filename, $content)
             $this->mkdir($dir);
         }
 
-        if (!is_writable($dir)) {
-            throw new IOException(sprintf('Unable to write to the "%s" directory.', $dir), 0, null, $dir);
-        }
-
         // Will create a temp file with 0600 access rights
         // when the filesystem supports chmod.
         $tmpFile = $this->tempnam($dir, basename($filename));
@@ -693,10 +689,6 @@ public function appendToFile(string $filename, $content)
             $this->mkdir($dir);
         }
 
-        if (!is_writable($dir)) {
-            throw new IOException(sprintf('Unable to write to the "%s" directory.', $dir), 0, null, $dir);
-        }
-
         if (false === self::box('file_put_contents', $filename, $content, \FILE_APPEND)) {
             throw new IOException(sprintf('Failed to write file "%s": ', $filename).self::$lastError, 0, null, $filename);
         }

Tests/FilesystemTest.php

@@ -1762,6 +1762,27 @@ public function testCopyShouldKeepExecutionPermission()
         $this->assertFilePermissions(767, $targetFilePath);
     }
 
+    public function testDumpToProtectedDirectory()
+    {
+        if (\DIRECTORY_SEPARATOR !== '\\') {
+            $this->markTestSkipped('This test is specific to Windows.');
+        }
+
+        if (($userProfilePath = getenv('USERPROFILE')) === false || !is_dir($userProfilePath)) {
+            throw new \RuntimeException('Failed to retrieve user profile path.');
+        }
+
+        $targetPath = implode(\DIRECTORY_SEPARATOR, [$userProfilePath, 'Downloads', '__test_file.ext']);
+
+        try {
+            $this->assertFileDoesNotExist($targetPath);
+            $this->filesystem->dumpFile($targetPath, 'foobar');
+            $this->assertFileExists($targetPath);
+        } finally {
+            $this->filesystem->remove($targetPath);
+        }
+    }
+
     /**
      * Normalize the given path (transform each forward slash into a real directory separator).
      */