Remove unnecessary empty usages

ostrolucky · ostrolucky · commit bddc353b1ad6 · 2024-04-01T13:34:39.000+02:00
diff --git a/Path.php b/Path.php
@@ -351,7 +351,7 @@ public static function changeExtension(string $path, string $extension): string
         }
 
         // No actual extension in path
-        if (empty($actualExtension)) {
+        if (!$actualExtension) {
             return $path.(str_ends_with($path, '.') ? '' : '.').$extension;
         }
 
diff --git a/Tests/FilesystemTestCase.php b/Tests/FilesystemTestCase.php
@@ -65,7 +65,7 @@ protected function setUp(): void
 
     protected function tearDown(): void
     {
-        if (!empty($this->longPathNamesWindows)) {
+        if ($this->longPathNamesWindows) {
             foreach ($this->longPathNamesWindows as $path) {
                 exec('DEL '.$path);
             }

Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,7 @@ public static function changeExtension(string $path, string $extension): string`
`351`	`351`	`}`
`352`	`352`
`353`	`353`	`// No actual extension in path`
`354`		`- if (empty($actualExtension)) {`
	`354`	`+ if (!$actualExtension) {`
`355`	`355`	`return $path.(str_ends_with($path, '.') ? '' : '.').$extension;`
`356`	`356`	`}`
`357`	`357`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ protected function setUp(): void`
`65`	`65`
`66`	`66`	`protected function tearDown(): void`
`67`	`67`	`{`
`68`		`- if (!empty($this->longPathNamesWindows)) {`
	`68`	`+ if ($this->longPathNamesWindows) {`
`69`	`69`	`foreach ($this->longPathNamesWindows as $path) {`
`70`	`70`	`exec('DEL '.$path);`
`71`	`71`	`}`