feature #51562 [DoctrineBridge] Add message to #[MapEntity] for NotFoundHttpException (moesoha)

This PR was merged into the 7.1 branch.

Discussion
----------

[DoctrineBridge] Add `message` to #[MapEntity] for NotFoundHttpException

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Allow the message in NotFoundHttpException to be overridden with the `message` argument in `#[MapEntity]`.

Commits
-------

753ad20d6f [DoctrineBridge] Add `message` to #[MapEntity] for NotFoundHttpException

Author: fabpot

ArgumentResolver/EntityValueResolver.php

@@ -73,7 +73,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
         }
 
         if (null === $object && !$argument->isNullable()) {
-            throw new NotFoundHttpException(sprintf('"%s" object not found by "%s".', $options->class, self::class).$message);
+            throw new NotFoundHttpException($options->message ?? (sprintf('"%s" object not found by "%s".', $options->class, self::class).$message));
         }
 
         return [$object];

Attribute/MapEntity.php

@@ -44,6 +44,7 @@ public function __construct(
         public ?bool $evictCache = null,
         bool $disabled = false,
         string $resolver = EntityValueResolver::class,
+        public ?string $message = null,
     ) {
         parent::__construct($resolver, $disabled);
     }
@@ -59,6 +60,7 @@ public function withDefaults(self $defaults, ?string $class): static
         $clone->stripNull ??= $defaults->stripNull ?? false;
         $clone->id ??= $defaults->id;
         $clone->evictCache ??= $defaults->evictCache ?? false;
+        $clone->message ??= $defaults->message;
 
         return $clone;
     }

Tests/ArgumentResolver/EntityValueResolverTest.php

@@ -153,7 +153,7 @@ public function testResolveWithConversionFailedException()
         $request = new Request();
         $request->attributes->set('id', 'test');
 
-        $argument = $this->createArgument('stdClass', new MapEntity(id: 'id'));
+        $argument = $this->createArgument('stdClass', new MapEntity(id: 'id', message: 'Test'));
 
         $repository = $this->getMockBuilder(ObjectRepository::class)->getMock();
         $repository->expects($this->once())
@@ -167,6 +167,7 @@ public function testResolveWithConversionFailedException()
             ->willReturn($repository);
 
         $this->expectException(NotFoundHttpException::class);
+        $this->expectExceptionMessage('Test');
 
         $resolver->resolve($request, $argument);
     }