Leverage non-capturing catches

Author: fancyweb

Form/DoctrineOrmTypeGuesser.php

@@ -176,9 +176,9 @@ protected function getMetadata(string $class)
         foreach ($this->registry->getManagers() as $name => $em) {
             try {
                 return $this->cache[$class] = [$em->getClassMetadata($class), $name];
-            } catch (MappingException $e) {
+            } catch (MappingException) {
                 // not an entity or mapped super class
-            } catch (LegacyMappingException $e) {
+            } catch (LegacyMappingException) {
                 // not an entity or mapped super class, using Doctrine ORM 2.2
             }
         }

Messenger/DoctrinePingConnectionMiddleware.php

@@ -39,7 +39,7 @@ private function pingConnection(EntityManagerInterface $entityManager)
 
         try {
             $connection->executeQuery($connection->getDatabasePlatform()->getDummySelectSQL());
-        } catch (DBALException $e) {
+        } catch (DBALException) {
             $connection->close();
             $connection->connect();
         }

PropertyInfo/DoctrineExtractor.php

@@ -212,7 +212,7 @@ private function getMetadata(string $class): ?ClassMetadata
     {
         try {
             return $this->entityManager->getClassMetadata($class);
-        } catch (MappingException|OrmMappingException $exception) {
+        } catch (MappingException|OrmMappingException) {
             return null;
         }
     }

Security/RememberMe/DoctrineTokenProvider.php

@@ -163,7 +163,7 @@ public function verifyToken(PersistentTokenInterface $token, string $tokenValue)
         // we also accept it as a valid value.
         try {
             $tmpToken = $this->loadTokenBySeries($tmpSeries);
-        } catch (TokenNotFoundException $e) {
+        } catch (TokenNotFoundException) {
             return false;
         }
 

Types/AbstractUidType.php

@@ -80,7 +80,7 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform): ?str
 
         try {
             return $this->getUidClass()::fromString($value)->$toString();
-        } catch (\InvalidArgumentException $e) {
+        } catch (\InvalidArgumentException) {
             throw ConversionException::conversionFailed($value, $this->getName());
         }
     }

Validator/DoctrineLoader.php

@@ -50,7 +50,7 @@ public function loadClassMetadata(ClassMetadata $metadata): bool
         $className = $metadata->getClassName();
         try {
             $doctrineMetadata = $this->entityManager->getClassMetadata($className);
-        } catch (MappingException|OrmMappingException $exception) {
+        } catch (MappingException|OrmMappingException) {
             return false;
         }