Remove unneeded calls to setPublic(false)

Author: nicolas-grekas

DependencyInjection/AbstractDoctrineExtension.php

@@ -188,7 +188,6 @@ protected function registerMappingDrivers(array $objectManager, ContainerBuilder
             $chainDriverDef = $container->getDefinition($this->getObjectManagerElementName($objectManager['name'].'_metadata_driver'));
         } else {
             $chainDriverDef = new Definition($this->getMetadataDriverClass('driver_chain'));
-            $chainDriverDef->setPublic(false);
         }
 
         foreach ($this->drivers as $driverType => $driverPaths) {
@@ -216,7 +215,6 @@ protected function registerMappingDrivers(array $objectManager, ContainerBuilder
                     array_values($driverPaths),
                 ]);
             }
-            $mappingDriverDef->setPublic(false);
             if (str_contains($mappingDriverDef->getClass(), 'yml') || str_contains($mappingDriverDef->getClass(), 'xml')) {
                 $mappingDriverDef->setArguments([array_flip($driverPaths)]);
                 $mappingDriverDef->addMethodCall('setGlobalBasename', ['mapping']);
@@ -386,8 +384,6 @@ protected function loadCacheDriver(string $cacheName, string $objectManagerName,
                 throw new \InvalidArgumentException(sprintf('"%s" is an unrecognized Doctrine cache driver.', $cacheDriver['type']));
         }
 
-        $cacheDef->setPublic(false);
-
         if (!isset($cacheDriver['namespace'])) {
             // generate a unique namespace for the given application
             if ($container->hasParameter('cache.prefix.seed')) {

Tests/DependencyInjection/CompilerPass/RegisterEventListenersAndSubscribersPassTest.php

@@ -59,7 +59,6 @@ public function testProcessEventListenersWithPriorities()
 
         $container
             ->register('a', 'stdClass')
-            ->setPublic(false)
             ->addTag('doctrine.event_listener', [
                 'event' => 'bar',
             ])
@@ -389,7 +388,6 @@ public function testProcessEventSubscribersAndListenersWithPriorities()
         ;
         $container
             ->register('f', 'stdClass')
-            ->setPublic(false)
             ->addTag('doctrine.event_listener', [
                 'event' => 'bar',
             ])
@@ -460,15 +458,13 @@ public function testSubscribersAreSkippedIfListenerDefinedForSameDefinition()
 
         $container
             ->register('a', 'stdClass')
-            ->setPublic(false)
             ->addTag('doctrine.event_listener', [
                 'event' => 'bar',
                 'priority' => 3,
             ])
         ;
         $container
             ->register('b', 'stdClass')
-            ->setPublic(false)
             ->addTag('doctrine.event_listener', [
                 'event' => 'bar',
             ])