minor #22066 fix some risky tests (xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

fix some risky tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

PHPUnit 6 marks tests as risky when they have no assertions (and are not marked as skipped or incomplete). This PR will update our test suite accordingly.

Component that still need to be covered:

- [ ] Config
- [ ] Form
- [ ] HttpFoundation
- [ ] Security
- [ ] Workflow

Commits
-------

abf1787dcc fix some risky tests

Author: fabpot

Tests/Compiler/CheckCircularReferencesPassTest.php

@@ -114,6 +114,8 @@ public function testProcessIgnoresMethodCalls()
         $container->register('b')->addMethodCall('setA', array(new Reference('a')));
 
         $this->process($container);
+
+        $this->addToAssertionCount(1);
     }
 
     protected function process(ContainerBuilder $container)

Tests/Compiler/CheckDefinitionValidityPassTest.php

@@ -72,6 +72,8 @@ public function testProcess()
         $container->register('d', 'class')->setSynthetic(true);
 
         $this->process($container);
+
+        $this->addToAssertionCount(1);
     }
 
     public function testValidTags()
@@ -83,6 +85,8 @@ public function testValidTags()
         $container->register('d', 'class')->addTag('foo', array('bar' => 1.1));
 
         $this->process($container);
+
+        $this->addToAssertionCount(1);
     }
 
     /**

Tests/Compiler/CheckExceptionOnInvalidReferenceBehaviorPassTest.php

@@ -28,6 +28,10 @@ public function testProcess()
             ->addArgument(new Reference('b'))
         ;
         $container->register('b', '\stdClass');
+
+        $this->process($container);
+
+        $this->addToAssertionCount(1);
     }
 
     /**

Tests/Compiler/CheckReferenceValidityPassTest.php

@@ -27,6 +27,8 @@ public function testProcessIgnoresScopeWideningIfNonStrictReference()
         $container->register('b')->setScope('prototype');
 
         $this->process($container);
+
+        $this->addToAssertionCount(1);
     }
 
     /**
@@ -39,6 +41,8 @@ public function testProcessDetectsScopeWidening()
         $container->register('b')->setScope('prototype');
 
         $this->process($container);
+
+        $this->addToAssertionCount(1);
     }
 
     public function testProcessIgnoresCrossScopeHierarchyReferenceIfNotStrict()
@@ -51,6 +55,8 @@ public function testProcessIgnoresCrossScopeHierarchyReferenceIfNotStrict()
         $container->register('b')->setScope('b');
 
         $this->process($container);
+
+        $this->addToAssertionCount(1);
     }
 
     /**
@@ -88,6 +94,8 @@ public function testProcess()
         $container->register('b');
 
         $this->process($container);
+
+        $this->addToAssertionCount(1);
     }
 
     protected function process(ContainerBuilder $container)

Tests/Dumper/PhpDumperTest.php

@@ -297,6 +297,8 @@ public function testCircularReferenceAllowanceForLazyServices()
 
         $dumper = new PhpDumper($container);
         $dumper->dump();
+
+        $this->addToAssertionCount(1);
     }
 
     public function testCircularReferenceAllowanceForInlinedDefinitionsForLazyServices()
@@ -334,5 +336,7 @@ public function testCircularReferenceAllowanceForInlinedDefinitionsForLazyServic
 
         $dumper->setProxyDumper(new DummyProxyDumper());
         $dumper->dump();
+
+        $this->addToAssertionCount(1);
     }
 }

Tests/Dumper/XmlDumperTest.php

@@ -162,6 +162,8 @@ public function testCompiledContainerCanBeDumped($containerFile)
         $container->compile();
         $dumper = new XmlDumper($container);
         $dumper->dump();
+
+        $this->addToAssertionCount(1);
     }
 
     public function provideCompiledContainerData()