Dont call sprintf() when no placeholders are used

nicolas-grekas · nicolas-grekas · commit 79809e84114d · 2017-04-04T20:32:29.000+02:00
diff --git a/Definition.php b/Definition.php
@@ -373,7 +373,7 @@ public function setMethodCalls(array $calls = array())
     public function addMethodCall($method, array $arguments = array())
     {
         if (empty($method)) {
-            throw new InvalidArgumentException(sprintf('Method name cannot be empty.'));
+            throw new InvalidArgumentException('Method name cannot be empty.');
         }
         $this->calls[] = array($method, $arguments);
 
diff --git a/Dumper/YamlDumper.php b/Dumper/YamlDumper.php
@@ -93,19 +93,19 @@ private function addService($id, $definition)
         }
 
         if ($definition->isSynthetic()) {
-            $code .= sprintf("        synthetic: true\n");
+            $code .= "        synthetic: true\n";
         }
 
         if ($definition->isSynchronized(false)) {
-            $code .= sprintf("        synchronized: true\n");
+            $code .= "        synchronized: true\n";
         }
 
         if ($definition->getFactoryClass(false)) {
             $code .= sprintf("        factory_class: %s\n", $this->dumper->dump($definition->getFactoryClass(false)));
         }
 
         if ($definition->isLazy()) {
-            $code .= sprintf("        lazy: true\n");
+            $code .= "        lazy: true\n";
         }
 
         if ($definition->getFactoryMethod(false)) {

Original file line number	Diff line number	Diff line change
`@@ -373,7 +373,7 @@ public function setMethodCalls(array $calls = array())`
`373`	`373`	`public function addMethodCall($method, array $arguments = array())`
`374`	`374`	`{`
`375`	`375`	`if (empty($method)) {`
`376`		`- throw new InvalidArgumentException(sprintf('Method name cannot be empty.'));`
	`376`	`+ throw new InvalidArgumentException('Method name cannot be empty.');`
`377`	`377`	`}`
`378`	`378`	`$this->calls[] = array($method, $arguments);`
`379`	`379`
Original file line number	Diff line number	Diff line change
`@@ -93,19 +93,19 @@ private function addService($id, $definition)`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`if ($definition->isSynthetic()) {`
`96`		`- $code .= sprintf(" synthetic: true\n");`
	`96`	`+ $code .= " synthetic: true\n";`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`if ($definition->isSynchronized(false)) {`
`100`		`- $code .= sprintf(" synchronized: true\n");`
	`100`	`+ $code .= " synchronized: true\n";`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`if ($definition->getFactoryClass(false)) {`
`104`	`104`	`$code .= sprintf(" factory_class: %s\n", $this->dumper->dump($definition->getFactoryClass(false)));`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`if ($definition->isLazy()) {`
`108`		`- $code .= sprintf(" lazy: true\n");`
	`108`	`+ $code .= " lazy: true\n";`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`if ($definition->getFactoryMethod(false)) {`