feature #1562 Use app global variable for locale (seb-jean)

javiereguiluz · javiereguiluz · commit a185a2a2c24c · 2025-02-24T09:57:37.000+01:00
This PR was merged into the main branch. Discussion ---------- Use app global variable for locale I updated the code to use the new global app variable; `app.locale`. URL: https://symfony.com/blog/new-in-symfony-6-3-dx-improvements-part-1#add-current-locale-to-the-app-variable Commits ------- fbb93e7 refactor: Use app.locale
diff --git a/templates/base.html.twig b/templates/base.html.twig
@@ -4,7 +4,7 @@
    See https://symfony.com/doc/current/templates.html#template-inheritance-and-layouts
 #}
 <!DOCTYPE html>
-<html lang="{{ app.request.locale }}">
+<html lang="{{ app.locale }}">
     <head>
         <meta charset="UTF-8" />
         <meta name="viewport" content="width=device-width, initial-scale=1"/>
@@ -102,7 +102,7 @@
                             {{ render_esi(controller('Symfony\\Bundle\\FrameworkBundle\\Controller\\TemplateController::templateAction', {
                                 'template': 'blog/about.html.twig',
                                 'sharedAge': 600,
-                                '_locale': app.request.locale
+                                '_locale': app.locale
                             })) }}
                         {% endblock %}
                     </div>
diff --git a/templates/blog/index.xml.twig b/templates/blog/index.xml.twig
@@ -6,7 +6,7 @@
         <pubDate>{{ 'now'|date('r', timezone='GMT') }}</pubDate>
         <lastBuildDate>{{ (paginator.results|last).publishedAt|default('now')|date('r', timezone='GMT') }}</lastBuildDate>
         <link>{{ url('blog_index') }}</link>
-        <language>{{ app.request.locale }}</language>
+        <language>{{ app.locale }}</language>
 
         {% for post in paginator.results %}
             <item>
diff --git a/templates/default/_language_selector.html.twig b/templates/default/_language_selector.html.twig
@@ -2,7 +2,7 @@
     <a href="#" class="nav-link dropdown-toggle language-selector-dropdown-button" data-toggle="modal" data-target="#locale-selector-modal" role="button" id="locales">
         <twig:ux:icon name="tabler:world"/>
         {% if display_current_language %}
-            <span class="current-language">{{ app.request.locale|locale_name }}</span>
+            <span class="current-language">{{ app.locale|locale_name }}</span>
         {% endif %}
         <span class="caret"></span>
         <span class="sr-only">{{ 'menu.choose_language'|trans }}</span>
@@ -24,7 +24,7 @@
                 <div class="modal-body">
                     <ul class="locales">
                         {% for locale in locales() %}
-                            {% set is_active = app.request.locale == locale.code %}
+                            {% set is_active = app.locale == locale.code %}
                             {% set is_rtl = locale.code in ['ar', 'fa', 'he'] %}
                             <li class="{{ is_active ? 'active' }} {{ is_rtl ? 'rtl' }}" translate="no">
                                 <a class="stretched-link" lang="{{ locale.code }}" hreflang="{{ locale.code }}" href="{{ path(app.current_route ?? 'blog_index', app.current_route_parameters|merge({_locale: locale.code})) }}">
