minor #839 Added more type hints and removed PHPdoc (javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

Added more type hints and removed PHPdoc

A follow-up of #837 after this comment from @stof: https://github.com/symfony/demo/pull/837/files/f8483c27636eafa5a56302ba6daac04dcd36e8fa#r204007113

Commits
-------

4f177c3 Added more type hints and removed PHPdoc

Author: javiereguiluz

src/Command/AddUserCommand.php

@@ -230,7 +230,7 @@ private function validateUserData($username, $plainPassword, $email, $fullName)
      * it's too long, it's better to define a separate method to maintain the
      * code readability.
      */
-    private function getCommandHelp()
+    private function getCommandHelp(): string
     {
         return <<<'HELP'
 The <info>%command.name%</info> command creates new users and saves them in the database:

src/Command/ListUsersCommand.php

@@ -127,11 +127,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
     /**
      * Sends the given $contents to the $recipient email address.
-     *
-     * @param string $contents
-     * @param string $recipient
      */
-    private function sendReport($contents, $recipient)
+    private function sendReport(string $contents, string $recipient): void
     {
         // See https://symfony.com/doc/current/cookbook/email/email.html
         $message = $this->mailer->createMessage()

src/Twig/AppExtension.php

@@ -33,7 +33,7 @@ class AppExtension extends AbstractExtension
     private $localeCodes;
     private $locales;
 
-    public function __construct(Markdown $parser, $locales)
+    public function __construct(Markdown $parser, string $locales)
     {
         $this->parser = $parser;
         $this->localeCodes = explode('|', $locales);

tests/Form/DataTransformer/TagArrayToStringTransformerTest.php

@@ -117,10 +117,8 @@ private function getMockedTransformer(array $findByReturnValues = []): TagArrayT
 
     /**
      * This helper method creates a Tag instance for the given tag name.
-     *
-     * @param string $name
      */
-    private function createTag($name): Tag
+    private function createTag(string $name): Tag
     {
         $tag = new Tag();
         $tag->setName($name);