fixed CS

fabpot · fabpot · commit 2c6ece8dae75 · 2019-01-16T21:35:37.000+01:00
diff --git a/Cache/CacheTrait.php b/Cache/CacheTrait.php
@@ -46,7 +46,7 @@ private function doGet(CacheItemPoolInterface $pool, string $key, callable $call
 
         $item = $pool->getItem($key);
         $recompute = !$item->isHit() || INF === $beta;
-        $metadata = $item instanceof ItemInterface ? $item->getMetadata() : array();
+        $metadata = $item instanceof ItemInterface ? $item->getMetadata() : [];
 
         if (!$recompute && $metadata) {
             $expiry = $metadata[ItemInterface::METADATA_EXPIRY] ?? false;
diff --git a/Service/ServiceLocatorTrait.php b/Service/ServiceLocatorTrait.php
@@ -23,7 +23,7 @@
 trait ServiceLocatorTrait
 {
     private $factories;
-    private $loading = array();
+    private $loading = [];
 
     /**
      * @param callable[] $factories
diff --git a/Service/ServiceSubscriberTrait.php b/Service/ServiceSubscriberTrait.php
@@ -32,7 +32,7 @@ public static function getSubscribedServices(): array
             return $services;
         }
 
-        $services = \is_callable(array('parent', __FUNCTION__)) ? parent::getSubscribedServices() : array();
+        $services = \is_callable(['parent', __FUNCTION__]) ? parent::getSubscribedServices() : [];
 
         foreach ((new \ReflectionClass(self::class))->getMethods() as $method) {
             if ($method->isStatic() || $method->isAbstract() || $method->isGenerator() || $method->isInternal() || $method->getNumberOfRequiredParameters()) {
@@ -54,7 +54,7 @@ public function setContainer(ContainerInterface $container)
     {
         $this->container = $container;
 
-        if (\is_callable(array('parent', __FUNCTION__))) {
+        if (\is_callable(['parent', __FUNCTION__])) {
             return parent::setContainer($container);
         }
     }
diff --git a/Tests/Cache/CacheTraitTest.php b/Tests/Cache/CacheTraitTest.php
@@ -34,7 +34,7 @@ public function testSave()
             ->with('computed data');
 
         $cache = $this->getMockBuilder(TestPool::class)
-            ->setMethods(array('getItem', 'save'))
+            ->setMethods(['getItem', 'save'])
             ->getMock();
         $cache->expects($this->once())
             ->method('getItem')
@@ -60,7 +60,7 @@ public function testNoCallbackCallOnHit()
             ->method('set');
 
         $cache = $this->getMockBuilder(TestPool::class)
-            ->setMethods(array('getItem', 'save'))
+            ->setMethods(['getItem', 'save'])
             ->getMock();
 
         $cache->expects($this->once())
@@ -91,7 +91,7 @@ public function testRecomputeOnBetaInf()
             ->with('computed data');
 
         $cache = $this->getMockBuilder(TestPool::class)
-            ->setMethods(array('getItem', 'save'))
+            ->setMethods(['getItem', 'save'])
             ->getMock();
 
         $cache->expects($this->once())
@@ -111,7 +111,7 @@ public function testRecomputeOnBetaInf()
     public function testExceptionOnNegativeBeta()
     {
         $cache = $this->getMockBuilder(TestPool::class)
-            ->setMethods(array('getItem', 'save'))
+            ->setMethods(['getItem', 'save'])
             ->getMock();
 
         $callback = function (CacheItemInterface $item) {
@@ -135,15 +135,15 @@ public function deleteItem($key)
     {
     }
 
-    public function deleteItems(array $keys = array())
+    public function deleteItems(array $keys = [])
     {
     }
 
     public function getItem($key)
     {
     }
 
-    public function getItems(array $key = array())
+    public function getItems(array $key = [])
     {
     }
 
diff --git a/Tests/Service/ServiceLocatorTest.php b/Tests/Service/ServiceLocatorTest.php
@@ -26,11 +26,11 @@ public function getServiceLocator(array $factories)
 
     public function testHas()
     {
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () { return 'bar'; },
             'bar' => function () { return 'baz'; },
             function () { return 'dummy'; },
-        ));
+        ]);
 
         $this->assertTrue($locator->has('foo'));
         $this->assertTrue($locator->has('bar'));
@@ -39,10 +39,10 @@ function () { return 'dummy'; },
 
     public function testGet()
     {
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () { return 'bar'; },
             'bar' => function () { return 'baz'; },
-        ));
+        ]);
 
         $this->assertSame('bar', $locator->get('foo'));
         $this->assertSame('baz', $locator->get('bar'));
@@ -51,13 +51,13 @@ public function testGet()
     public function testGetDoesNotMemoize()
     {
         $i = 0;
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () use (&$i) {
                 ++$i;
 
                 return 'bar';
             },
-        ));
+        ]);
 
         $this->assertSame('bar', $locator->get('foo'));
         $this->assertSame('bar', $locator->get('foo'));
@@ -70,9 +70,9 @@ public function testGetDoesNotMemoize()
      */
     public function testThrowsOnUndefinedInternalService()
     {
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () use (&$locator) { return $locator->get('bar'); },
-        ));
+        ]);
 
         $locator->get('foo');
     }
@@ -83,11 +83,11 @@ public function testThrowsOnUndefinedInternalService()
      */
     public function testThrowsOnCircularReference()
     {
-        $locator = $this->getServiceLocator(array(
+        $locator = $this->getServiceLocator([
             'foo' => function () use (&$locator) { return $locator->get('bar'); },
             'bar' => function () use (&$locator) { return $locator->get('baz'); },
             'baz' => function () use (&$locator) { return $locator->get('bar'); },
-        ));
+        ]);
 
         $locator->get('foo');
     }
diff --git a/Tests/Service/ServiceSubscriberTraitTest.php b/Tests/Service/ServiceSubscriberTraitTest.php
@@ -21,14 +21,14 @@ class ServiceSubscriberTraitTest extends TestCase
 {
     public function testMethodsOnParentsAndChildrenAreIgnoredInGetSubscribedServices()
     {
-        $expected = array(TestService::class.'::aService' => '?Symfony\Contracts\Tests\Service\Service2');
+        $expected = [TestService::class.'::aService' => '?Symfony\Contracts\Tests\Service\Service2'];
 
         $this->assertEquals($expected, ChildTestService::getSubscribedServices());
     }
 
     public function testSetContainerIsCalledOnParent()
     {
-        $container = new class(array()) implements ContainerInterface {
+        $container = new class([]) implements ContainerInterface {
             use ServiceLocatorTrait;
         };
 
diff --git a/Tests/Translation/TranslatorTest.php b/Tests/Translation/TranslatorTest.php
diff --git a/Translation/TranslatorInterface.php b/Translation/TranslatorInterface.php
diff --git a/Translation/TranslatorTrait.php b/Translation/TranslatorTrait.php

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`trait ServiceLocatorTrait`
`24`	`24`	`{`
`25`	`25`	`private $factories;`
`26`		`- private $loading = array();`
	`26`	`+ private $loading = [];`
`27`	`27`
`28`	`28`	`/**`
`29`	`29`	`* @param callable[] $factories`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public static function getSubscribedServices(): array`
`32`	`32`	`return $services;`
`33`	`33`	`}`
`34`	`34`
`35`		`- $services = \is_callable(array('parent', __FUNCTION__)) ? parent::getSubscribedServices() : array();`
	`35`	`+ $services = \is_callable(['parent', __FUNCTION__]) ? parent::getSubscribedServices() : [];`
`36`	`36`
`37`	`37`	`foreach ((new \ReflectionClass(self::class))->getMethods() as $method) {`
`38`	`38`	`if ($method->isStatic() \|\| $method->isAbstract() \|\| $method->isGenerator() \|\| $method->isInternal() \|\| $method->getNumberOfRequiredParameters()) {`
`@@ -54,7 +54,7 @@ public function setContainer(ContainerInterface $container)`
`54`	`54`	`{`
`55`	`55`	`$this->container = $container;`
`56`	`56`
`57`		`- if (\is_callable(array('parent', __FUNCTION__))) {`
	`57`	`+ if (\is_callable(['parent', __FUNCTION__])) {`
`58`	`58`	`return parent::setContainer($container);`
`59`	`59`	`}`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function testSave()`
`34`	`34`	`->with('computed data');`
`35`	`35`
`36`	`36`	`$cache = $this->getMockBuilder(TestPool::class)`
`37`		`- ->setMethods(array('getItem', 'save'))`
	`37`	`+ ->setMethods(['getItem', 'save'])`
`38`	`38`	`->getMock();`
`39`	`39`	`$cache->expects($this->once())`
`40`	`40`	`->method('getItem')`
`@@ -60,7 +60,7 @@ public function testNoCallbackCallOnHit()`
`60`	`60`	`->method('set');`
`61`	`61`
`62`	`62`	`$cache = $this->getMockBuilder(TestPool::class)`
`63`		`- ->setMethods(array('getItem', 'save'))`
	`63`	`+ ->setMethods(['getItem', 'save'])`
`64`	`64`	`->getMock();`
`65`	`65`
`66`	`66`	`$cache->expects($this->once())`
`@@ -91,7 +91,7 @@ public function testRecomputeOnBetaInf()`
`91`	`91`	`->with('computed data');`
`92`	`92`
`93`	`93`	`$cache = $this->getMockBuilder(TestPool::class)`
`94`		`- ->setMethods(array('getItem', 'save'))`
	`94`	`+ ->setMethods(['getItem', 'save'])`
`95`	`95`	`->getMock();`
`96`	`96`
`97`	`97`	`$cache->expects($this->once())`
`@@ -111,7 +111,7 @@ public function testRecomputeOnBetaInf()`
`111`	`111`	`public function testExceptionOnNegativeBeta()`
`112`	`112`	`{`
`113`	`113`	`$cache = $this->getMockBuilder(TestPool::class)`
`114`		`- ->setMethods(array('getItem', 'save'))`
	`114`	`+ ->setMethods(['getItem', 'save'])`
`115`	`115`	`->getMock();`
`116`	`116`
`117`	`117`	`$callback = function (CacheItemInterface $item) {`
`@@ -135,15 +135,15 @@ public function deleteItem($key)`
`135`	`135`	`{`
`136`	`136`	`}`
`137`	`137`
`138`		`- public function deleteItems(array $keys = array())`
	`138`	`+ public function deleteItems(array $keys = [])`
`139`	`139`	`{`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`public function getItem($key)`
`143`	`143`	`{`
`144`	`144`	`}`
`145`	`145`
`146`		`- public function getItems(array $key = array())`
	`146`	`+ public function getItems(array $key = [])`
`147`	`147`	`{`
`148`	`148`	`}`
`149`	`149`
Original file line number	Diff line number	Diff line change
`@@ -21,14 +21,14 @@ class ServiceSubscriberTraitTest extends TestCase`
`21`	`21`	`{`
`22`	`22`	`public function testMethodsOnParentsAndChildrenAreIgnoredInGetSubscribedServices()`
`23`	`23`	`{`
`24`		`- $expected = array(TestService::class.'::aService' => '?Symfony\Contracts\Tests\Service\Service2');`
	`24`	`+ $expected = [TestService::class.'::aService' => '?Symfony\Contracts\Tests\Service\Service2'];`
`25`	`25`
`26`	`26`	`$this->assertEquals($expected, ChildTestService::getSubscribedServices());`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`public function testSetContainerIsCalledOnParent()`
`30`	`30`	`{`
`31`		`- $container = new class(array()) implements ContainerInterface {`
	`31`	`+ $container = new class([]) implements ContainerInterface {`
`32`	`32`	`use ServiceLocatorTrait;`
`33`	`33`	`};`
`34`	`34`