Optimize perf by replacing call_user_func with dynamic vars

Author: ostrolucky

Command/Command.php

@@ -250,7 +250,7 @@ public function run(InputInterface $input, OutputInterface $output)
         $input->validate();
 
         if ($this->code) {
-            $statusCode = \call_user_func($this->code, $input, $output);
+            $statusCode = ($this->code)($input, $output);
         } else {
             $statusCode = $this->execute($input, $output);
         }

Helper/ProcessHelper.php

@@ -121,7 +121,7 @@ public function wrapCallback(OutputInterface $output, Process $process, callable
             $output->write($formatter->progress(spl_object_hash($process), $this->escapeString($buffer), Process::ERR === $type));
 
             if (null !== $callback) {
-                \call_user_func($callback, $type, $buffer);
+                $callback($type, $buffer);
             }
         };
     }

Helper/ProgressBar.php

@@ -496,7 +496,7 @@ private function buildLine(): string
         $regex = "{%([a-z\-_]+)(?:\:([^%]+))?%}i";
         $callback = function ($matches) {
             if ($formatter = $this::getPlaceholderFormatterDefinition($matches[1])) {
-                $text = \call_user_func($formatter, $this, $this->output);
+                $text = $formatter($this, $this->output);
             } elseif (isset($this->messages[$matches[1]])) {
                 $text = $this->messages[$matches[1]];
             } else {

Helper/ProgressIndicator.php

@@ -196,7 +196,7 @@ private function display()
 
         $this->overwrite(preg_replace_callback("{%([a-z\-_]+)(?:\:([^%]+))?%}i", function ($matches) use ($self) {
             if ($formatter = $self::getPlaceholderFormatterDefinition($matches[1])) {
-                return \call_user_func($formatter, $self);
+                return $formatter($self);
             }
 
             return $matches[0];

Helper/QuestionHelper.php

@@ -381,7 +381,7 @@ private function validateAttempts(callable $interviewer, OutputInterface $output
             }
 
             try {
-                return \call_user_func($question->getValidator(), $interviewer());
+                return $question->getValidator()($interviewer());
             } catch (RuntimeException $e) {
                 throw $e;
             } catch (\Exception $error) {