Add return types to tests and final|internal|private methods

Author: nicolas-grekas

Tests/Definition/Builder/ExprBuilderTest.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Config\Tests\Definition\Builder;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Config\Definition\Builder\ExprBuilder;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 
 class ExprBuilderTest extends TestCase
@@ -201,10 +202,8 @@ public function testEndThenPartNotSpecified()
 
     /**
      * Create a test treebuilder with a variable node, and init the validation.
-     *
-     * @return TreeBuilder
      */
-    protected function getTestBuilder()
+    protected function getTestBuilder(): ExprBuilder
     {
         $builder = new TreeBuilder('test');
 
@@ -225,7 +224,7 @@ protected function getTestBuilder()
      *
      * @return array The finalized config values
      */
-    protected function finalizeTestBuilder($testBuilder, $config = null)
+    protected function finalizeTestBuilder($testBuilder, $config = null): array
     {
         return $testBuilder
             ->end()
@@ -240,10 +239,8 @@ protected function finalizeTestBuilder($testBuilder, $config = null)
      * Return a closure that will return the given value.
      *
      * @param mixed $val The value that the closure must return
-     *
-     * @return \Closure
      */
-    protected function returnClosure($val)
+    protected function returnClosure($val): \Closure
     {
         return function ($v) use ($val) {
             return $val;

Tests/Fixtures/Builder/BarNodeDefinition.php

@@ -12,11 +12,12 @@
 namespace Symfony\Component\Config\Tests\Fixtures\Builder;
 
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
+use Symfony\Component\Config\Definition\NodeInterface;
 use Symfony\Component\Config\Tests\Fixtures\BarNode;
 
 class BarNodeDefinition extends NodeDefinition
 {
-    protected function createNode()
+    protected function createNode(): NodeInterface
     {
         return new BarNode($this->name);
     }

Tests/Fixtures/Builder/NodeBuilder.php

@@ -20,7 +20,7 @@ public function barNode($name)
         return $this->node($name, 'bar');
     }
 
-    protected function getNodeClass($type)
+    protected function getNodeClass($type): string
     {
         switch ($type) {
             case 'variable':

Tests/Fixtures/Configuration/ExampleConfiguration.php

@@ -16,7 +16,7 @@
 
 class ExampleConfiguration implements ConfigurationInterface
 {
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('acme_root');
 

Tests/Loader/FileLoaderTest.php

@@ -103,7 +103,7 @@ public function load($resource, $type = null)
         return $resource;
     }
 
-    public function supports($resource, $type = null)
+    public function supports($resource, $type = null): bool
     {
         return $this->supports;
     }

Tests/Loader/LoaderTest.php

@@ -105,7 +105,7 @@ public function load($resource, $type = null)
     {
     }
 
-    public function supports($resource, $type = null)
+    public function supports($resource, $type = null): bool
     {
         return \is_string($resource) && 'foo' === pathinfo($resource, PATHINFO_EXTENSION);
     }

Tests/Resource/ReflectionClassResourceTest.php

@@ -204,7 +204,7 @@ class TestEventSubscriber implements EventSubscriberInterface
 {
     public static $subscribedEvents = [];
 
-    public static function getSubscribedEvents()
+    public static function getSubscribedEvents(): array
     {
         return self::$subscribedEvents;
     }
@@ -228,7 +228,7 @@ class TestServiceSubscriber implements ServiceSubscriberInterface
 {
     public static $subscribedServices = [];
 
-    public static function getSubscribedServices()
+    public static function getSubscribedServices(): array
     {
         return self::$subscribedServices;
     }

Tests/Resource/ResourceStub.php

@@ -22,12 +22,12 @@ public function setFresh($isFresh)
         $this->fresh = $isFresh;
     }
 
-    public function __toString()
+    public function __toString(): string
     {
         return 'stub';
     }
 
-    public function isFresh($timestamp)
+    public function isFresh($timestamp): bool
     {
         return $this->fresh;
     }