Convert public properties to private in agent component

Author: chr-hertel

examples/toolbox/weather-event.php

@@ -32,9 +32,9 @@
 
 // Add tool call result listener to enforce chain exits direct with structured response for weather tools
 $eventDispatcher->addListener(ToolCallsExecuted::class, function (ToolCallsExecuted $event): void {
-    foreach ($event->toolResults as $toolCallResult) {
-        if (str_starts_with($toolCallResult->toolCall->getName(), 'weather_')) {
-            $event->result = new ObjectResult($toolCallResult->result);
+    foreach ($event->getToolResults() as $toolCallResult) {
+        if (str_starts_with($toolCallResult->getToolCall()->getName(), 'weather_')) {
+            $event->setResult(new ObjectResult($toolCallResult->getResult()));
         }
     }
 });

src/agent/src/Memory/Memory.php

@@ -16,7 +16,13 @@
  */
 final readonly class Memory
 {
-    public function __construct(public string $content)
+    public function __construct(
+        private string $content,
+    ) {
+    }
+
+    public function getContent(): string
     {
+        return $this->content;
     }
 }

src/agent/src/Memory/MemoryInputProcessor.php

@@ -61,7 +61,7 @@ public function processInput(Input $input): void
             $memory .= \PHP_EOL.\PHP_EOL;
             $memory .= implode(
                 \PHP_EOL,
-                array_map(static fn (Memory $memory): string => $memory->content, $memoryMessages),
+                array_map(static fn (Memory $memory): string => $memory->getContent(), $memoryMessages),
             );
         }
 

src/agent/src/MultiAgent/Handoff/Decision.php

@@ -23,8 +23,8 @@
      * @param string $reasoning The reasoning behind the selection
      */
     public function __construct(
-        public string $agentName,
-        public string $reasoning = 'No reasoning provided',
+        private string $agentName,
+        private string $reasoning = 'No reasoning provided',
     ) {
     }
 
@@ -35,4 +35,14 @@ public function hasAgent(): bool
     {
         return '' !== $this->agentName;
     }
+
+    public function getAgentName(): string
+    {
+        return $this->agentName;
+    }
+
+    public function getReasoning(): string
+    {
+        return $this->reasoning;
+    }
 }

src/agent/src/MultiAgent/MultiAgent.php

@@ -91,8 +91,8 @@ public function call(MessageBag $messages, array $options = []): ResultInterface
         }
 
         $this->logger->debug('MultiAgent: Agent selection completed', [
-            'selected_agent' => $decision->agentName,
-            'reasoning' => $decision->reasoning,
+            'selected_agent' => $decision->getAgentName(),
+            'reasoning' => $decision->getReasoning(),
         ]);
 
         if (!$decision->hasAgent()) {
@@ -104,22 +104,22 @@ public function call(MessageBag $messages, array $options = []): ResultInterface
         // Find the target agent by name
         $targetAgent = null;
         foreach ($this->handoffs as $handoff) {
-            if ($handoff->getTo()->getName() === $decision->agentName) {
+            if ($handoff->getTo()->getName() === $decision->getAgentName()) {
                 $targetAgent = $handoff->getTo();
                 break;
             }
         }
 
         if (!$targetAgent) {
             $this->logger->debug('MultiAgent: Target agent not found, using fallback agent', [
-                'requested_agent' => $decision->agentName,
+                'requested_agent' => $decision->getAgentName(),
                 'reason' => 'agent_not_found',
             ]);
 
             return $this->fallback->call($messages, $options);
         }
 
-        $this->logger->debug('MultiAgent: Delegating to agent', ['agent_name' => $decision->agentName]);
+        $this->logger->debug('MultiAgent: Delegating to agent', ['agent_name' => $decision->getAgentName()]);
 
         // Call the selected agent with the original user question
         return $targetAgent->call(new MessageBag($userMessage), $options);

src/agent/src/Toolbox/AgentProcessor.php

@@ -107,7 +107,7 @@ private function handleToolCallsCallback(Output $output): \Closure
                 $event = new ToolCallsExecuted(...$results);
                 $this->eventDispatcher?->dispatch($event);
 
-                $result = $event->hasResponse() ? $event->result : $this->agent->call($messages, $output->getOptions());
+                $result = $event->hasResponse() ? $event->getResult() : $this->agent->call($messages, $output->getOptions());
             } while ($result instanceof ToolCallResult);
 
             return $result;

src/agent/src/Toolbox/Event/ToolCallArgumentsResolved.php

@@ -24,9 +24,27 @@
      * @param array<string, mixed> $arguments
      */
     public function __construct(
-        public object $tool,
-        public Tool $metadata,
-        public array $arguments,
+        private object $tool,
+        private Tool $metadata,
+        private array $arguments,
     ) {
     }
+
+    public function getTool(): object
+    {
+        return $this->tool;
+    }
+
+    public function getMetadata(): Tool
+    {
+        return $this->metadata;
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    public function getArguments(): array
+    {
+        return $this->arguments;
+    }
 }

src/agent/src/Toolbox/Event/ToolCallFailed.php

@@ -22,10 +22,33 @@
      * @param array<string, mixed> $arguments
      */
     public function __construct(
-        public object $tool,
-        public Tool $metadata,
-        public array $arguments,
-        public \Throwable $exception,
+        private object $tool,
+        private Tool $metadata,
+        private array $arguments,
+        private \Throwable $exception,
     ) {
     }
+
+    public function getTool(): object
+    {
+        return $this->tool;
+    }
+
+    public function getMetadata(): Tool
+    {
+        return $this->metadata;
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    public function getArguments(): array
+    {
+        return $this->arguments;
+    }
+
+    public function getException(): \Throwable
+    {
+        return $this->exception;
+    }
 }

src/agent/src/Toolbox/Event/ToolCallSucceeded.php

@@ -22,10 +22,33 @@
      * @param array<string, mixed> $arguments
      */
     public function __construct(
-        public object $tool,
-        public Tool $metadata,
-        public array $arguments,
-        public mixed $result,
+        private object $tool,
+        private Tool $metadata,
+        private array $arguments,
+        private mixed $result,
     ) {
     }
+
+    public function getTool(): object
+    {
+        return $this->tool;
+    }
+
+    public function getMetadata(): Tool
+    {
+        return $this->metadata;
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    public function getArguments(): array
+    {
+        return $this->arguments;
+    }
+
+    public function getResult(): mixed
+    {
+        return $this->result;
+    }
 }

src/agent/src/Toolbox/Event/ToolCallsExecuted.php

@@ -22,8 +22,8 @@ final class ToolCallsExecuted
     /**
      * @var ToolResult[]
      */
-    public readonly array $toolResults;
-    public ResultInterface $result;
+    private readonly array $toolResults;
+    private ResultInterface $result;
 
     public function __construct(ToolResult ...$toolResults)
     {
@@ -34,4 +34,22 @@ public function hasResponse(): bool
     {
         return isset($this->result);
     }
+
+    public function setResult(ResultInterface $result): void
+    {
+        $this->result = $result;
+    }
+
+    public function getResult(): ResultInterface
+    {
+        return $this->result;
+    }
+
+    /**
+     * @return ToolResult[]
+     */
+    public function getToolResults(): array
+    {
+        return $this->toolResults;
+    }
 }