minor #665 [PHPStan] Replace custom ForbidEmptyRule with phpstan-strict-rules DisallowEmptyRule (OskarStark)

This PR was squashed before being merged into the main branch.

Discussion
----------

[PHPStan] Replace custom `ForbidEmptyRule` with phpstan-strict-rules `DisallowEmptyRule`

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Docs?         | no
| Issues        | Reworks #663
| License       | MIT

Commits
-------

1aeb98d [PHPStan] Replace custom `ForbidEmptyRule` with phpstan-strict-rules `DisallowEmptyRule`

Author: OskarStark

.phpstan/ForbidEmptyRule.php

@@ -1,5 +1,20 @@
-rules:
-    - Symfony\AI\PHPStan\ForbidDeclareStrictTypesRule
-    - Symfony\AI\PHPStan\ForbidNativeExceptionRule
-    - Symfony\AI\PHPStan\ForbidTestCoverageAttributesRule
-    - Symfony\AI\PHPStan\ForbidEmptyRule
+parameters:
+    customRulesetUsed: true
+
+services:
+    -
+        class: PHPStan\Rules\DisallowedConstructs\DisallowedEmptyRule
+        tags:
+            - phpstan.rules.rule
+    -
+        class: Symfony\AI\PHPStan\ForbidDeclareStrictTypesRule
+        tags:
+            - phpstan.rules.rule
+    -
+        class: Symfony\AI\PHPStan\ForbidNativeExceptionRule
+        tags:
+            - phpstan.rules.rule
+    -
+        class: Symfony\AI\PHPStan\ForbidTestCoverageAttributesRule
+        tags:
+            - phpstan.rules.rule

.phpstan/extension.neon

@@ -8,6 +8,7 @@
     "require-dev": {
         "php": ">=8.2",
         "php-cs-fixer/shim": "^3.75",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "symfony/filesystem": "^7.3|^8.0",
         "symfony/finder": "^7.3|^8.0"
     },

composer.json

@@ -40,6 +40,7 @@
     "require-dev": {
         "php-cs-fixer/shim": "^3.75",
         "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5",
         "symfony/browser-kit": "~7.3.0",
         "symfony/debug-bundle": "~7.3.0",

demo/composer.json

@@ -32,7 +32,8 @@
         "symfony/var-dumper": "^7.3|^8.0"
     },
     "require-dev": {
-        "phpstan/phpstan": "^2.1"
+        "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-strict-rules": "^2.0"
     },
     "minimum-stability": "dev",
     "autoload": {

examples/composer.json

@@ -35,6 +35,7 @@
     "require-dev": {
         "mrmysql/youtube-transcript": "^0.0.5",
         "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.13",
         "symfony/ai-store": "@dev",
         "symfony/cache": "^7.3|^8.0",

src/agent/composer.json

@@ -27,6 +27,7 @@
     "require-dev": {
         "google/auth": "^1.47",
         "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5",
         "symfony/expression-language": "^7.3|^8.0",
         "symfony/security-core": "^7.3|^8.0"

src/ai-bundle/composer.json

@@ -20,3 +20,6 @@ parameters:
             message: '#method_exists\(\) with Symfony\\Component\\Security\\Core\\Exception\\AccessDeniedException and ''setAccessDecision'' will always evaluate to true#'
             path: src/*
             reportUnmatched: false # only needed for Symfony < 7.3 versions
+        -
+            identifier: empty.notAllowed
+            path: config/options.php

src/ai-bundle/phpstan.dist.neon

@@ -21,6 +21,7 @@
     },
     "require-dev": {
         "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5"
     },
     "minimum-stability": "dev",

src/mcp-bundle/composer.json

@@ -20,6 +20,7 @@
     },
     "require-dev": {
         "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5",
         "psr/cache": "^3.0",
         "symfony/console": "^7.3|^8.0"