feature #723 [Platform] Use int for retry after (VincentLanglet)

This PR was merged into the main branch.

Discussion
----------

[Platform] Use int for retry after

| Q             | A
| ------------- | ---
| Bug fix?      | not really
| New feature?  | no
| Docs?         | no <!-- required for new features -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

According to RFC 7231 should be an integer
https://datatracker.ietf.org/doc/html/rfc7231#page-69

So let's avoid a useless float here.

Commits
-------

d968812 Use int for retry after

Author: OskarStark

src/platform/src/Bridge/Anthropic/ResultConverter.php

@@ -42,7 +42,7 @@ public function convert(RawHttpResult|RawResultInterface $result, array $options
 
         if (429 === $response->getStatusCode()) {
             $retryAfter = $response->getHeaders(false)['retry-after'][0] ?? null;
-            $retryAfterValue = $retryAfter ? (float) $retryAfter : null;
+            $retryAfterValue = $retryAfter ? (int) $retryAfter : null;
             throw new RateLimitExceededException($retryAfterValue);
         }
 

src/platform/src/Bridge/OpenAi/Gpt/ResultConverter.php

@@ -58,15 +58,11 @@ public function convert(RawResultInterface|RawHttpResult $result, array $options
 
         if (429 === $response->getStatusCode()) {
             $headers = $response->getHeaders(false);
-            $resetTime = null;
+            $resetTime = $headers['x-ratelimit-reset-requests'][0]
+                ?? $headers['x-ratelimit-reset-tokens'][0]
+                ?? null;
 
-            if (isset($headers['x-ratelimit-reset-requests'][0])) {
-                $resetTime = self::parseResetTime($headers['x-ratelimit-reset-requests'][0]);
-            } elseif (isset($headers['x-ratelimit-reset-tokens'][0])) {
-                $resetTime = self::parseResetTime($headers['x-ratelimit-reset-tokens'][0]);
-            }
-
-            throw new RateLimitExceededException($resetTime);
+            throw new RateLimitExceededException($resetTime ? self::parseResetTime($resetTime) : null);
         }
 
         if ($options['stream'] ?? false) {
@@ -221,16 +217,15 @@ private function convertToolCall(array $toolCall): ToolCall
      * - "6m0s"
      * - "2m30s"
      */
-    private static function parseResetTime(string $resetTime): float
+    private static function parseResetTime(string $resetTime): ?int
     {
-        $seconds = 0;
-
         if (preg_match('/^(?:(\d+)m)?(?:(\d+)s)?$/', $resetTime, $matches)) {
             $minutes = isset($matches[1]) ? (int) $matches[1] : 0;
             $secs = isset($matches[2]) ? (int) $matches[2] : 0;
-            $seconds = ($minutes * 60) + $secs;
+
+            return ($minutes * 60) + $secs;
         }
 
-        return (float) $seconds;
+        return null;
     }
 }

src/platform/src/Exception/RateLimitExceededException.php

@@ -17,12 +17,12 @@
 final class RateLimitExceededException extends RuntimeException
 {
     public function __construct(
-        private readonly ?float $retryAfter = null,
+        private readonly ?int $retryAfter = null,
     ) {
         parent::__construct('Rate limit exceeded.');
     }
 
-    public function getRetryAfter(): ?float
+    public function getRetryAfter(): ?int
     {
         return $this->retryAfter;
     }

src/platform/tests/Bridge/Anthropic/ResultConverterRateLimitTest.php

@@ -40,7 +40,7 @@ public function testRateLimitExceededThrowsException()
         try {
             $handler->convert(new RawHttpResult($httpResponse));
         } catch (RateLimitExceededException $e) {
-            $this->assertSame(60.0, $e->getRetryAfter());
+            $this->assertSame(60, $e->getRetryAfter());
             throw $e;
         }
     }

src/platform/tests/Bridge/OpenAi/Gpt/ResultConverterRateLimitTest.php

@@ -42,7 +42,7 @@ public function testRateLimitExceededWithRequestsResetTime()
         try {
             $handler->convert(new RawHttpResult($httpResponse));
         } catch (RateLimitExceededException $e) {
-            $this->assertSame(20.0, $e->getRetryAfter());
+            $this->assertSame(20, $e->getRetryAfter());
             throw $e;
         }
     }
@@ -69,7 +69,7 @@ public function testRateLimitExceededWithTokensResetTime()
         try {
             $handler->convert(new RawHttpResult($httpResponse));
         } catch (RateLimitExceededException $e) {
-            $this->assertSame(150.0, $e->getRetryAfter());
+            $this->assertSame(150, $e->getRetryAfter());
             throw $e;
         }
     }