bug #390 [Store][SurrealDB] Improve request and fix drop method (Guikingone)

This PR was merged into the main branch.

Discussion
----------

[Store][SurrealDB] Improve `request` and fix `drop` method

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Docs?         | yes
| Issues        | None
| License       | MIT

Hi 👋🏻

Here's the fix sur `SurrealDB` as discussed in #335

Commits
-------

8c45d4c ref(store): SurrealDB

Author: OskarStark

src/store/src/Bridge/SurrealDb/Store.php

@@ -75,6 +75,8 @@ public function query(Vector $vector, array $options = []): array
 
     public function drop(): void
     {
+        $this->authenticate();
+
         $this->request('DELETE', \sprintf('key/%s', $this->table), []);
     }
 
@@ -87,25 +89,32 @@ private function request(string $method, string $endpoint, array|string $payload
     {
         $url = \sprintf('%s/%s', $this->endpointUrl, $endpoint);
 
-        $finalPayload = [
-            'json' => $payload,
-        ];
+        $finalPayload = [];
+
+        if (\is_array($payload) && [] !== $payload) {
+            $finalPayload = [
+                'body' => $payload,
+            ];
+        }
 
         if (\is_string($payload)) {
             $finalPayload = [
                 'body' => $payload,
             ];
         }
 
-        $response = $this->httpClient->request($method, $url, array_merge($finalPayload, [
-            'headers' => [
-                'Accept' => 'application/json',
-                'Content-Type' => 'application/json',
-                'Surreal-NS' => $this->namespace,
-                'Surreal-DB' => $this->database,
-                'Authorization' => \sprintf('Bearer %s', $this->authenticationToken),
+        $response = $this->httpClient->request($method, $url, [
+            ...$finalPayload,
+            ...[
+                'headers' => [
+                    'Accept' => 'application/json',
+                    'Content-Type' => 'application/json',
+                    'Surreal-NS' => $this->namespace,
+                    'Surreal-DB' => $this->database,
+                    'Authorization' => \sprintf('Bearer %s', $this->authenticationToken),
+                ],
             ],
-        ]));
+        ]);
 
         return $response->toArray();
     }

src/store/tests/Bridge/SurrealDb/StoreTest.php

@@ -97,6 +97,13 @@ public function testStoreCanSetupOnValidAuthenticationAndIndexResponse()
     public function testStoreCannotDropOnInvalidResponse()
     {
         $httpClient = new MockHttpClient([
+            new JsonMockResponse([
+                'code' => 200,
+                'details' => 'Authentication succeeded.',
+                'token' => 'bar',
+            ], [
+                'http_code' => 200,
+            ]),
             new JsonMockResponse([], [
                 'http_code' => 400,
             ]),
@@ -129,6 +136,13 @@ public function testStoreCanDrop()
             ], [
                 'http_code' => 200,
             ]),
+            new JsonMockResponse([
+                'code' => 200,
+                'details' => 'Authentication succeeded.',
+                'token' => 'bar',
+            ], [
+                'http_code' => 200,
+            ]),
             new JsonMockResponse([], [
                 'http_code' => 200,
             ]),