Skip to content

Commit 0364837

Browse files
committed
Remove incorrect #[SensitiveParameter] attributes from store configuration parameters
- Remove #[\SensitiveParameter] from Typesense collection name (not sensitive) - Remove #[\SensitiveParameter] from Neo4j username and databaseName (not sensitive) - Remove #[\SensitiveParameter] from SurrealDB user, namespace and database (not sensitive) Only passwords and API keys should be marked as sensitive parameters.
1 parent 949bc7f commit 0364837

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/store/src/Bridge/Neo4j/Store.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
public function __construct(
3030
private HttpClientInterface $httpClient,
3131
private string $endpointUrl,
32-
#[\SensitiveParameter] private string $username,
32+
private string $username,
3333
#[\SensitiveParameter] private string $password,
34-
#[\SensitiveParameter] private string $databaseName,
34+
private string $databaseName,
3535
private string $vectorIndexName,
3636
private string $nodeName,
3737
private string $embeddingsField = 'embeddings',

src/store/src/Bridge/SurrealDb/Store.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ final class Store implements ManagedStoreInterface, StoreInterface
3232
public function __construct(
3333
private readonly HttpClientInterface $httpClient,
3434
private readonly string $endpointUrl,
35-
#[\SensitiveParameter] private readonly string $user,
35+
private readonly string $user,
3636
#[\SensitiveParameter] private readonly string $password,
37-
#[\SensitiveParameter] private readonly string $namespace,
38-
#[\SensitiveParameter] private readonly string $database,
37+
private readonly string $namespace,
38+
private readonly string $database,
3939
private readonly string $table = 'vectors',
4040
private readonly string $vectorFieldName = '_vectors',
4141
private readonly string $strategy = 'cosine',

src/store/src/Bridge/Typesense/Store.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function __construct(
3030
private HttpClientInterface $httpClient,
3131
private string $endpointUrl,
3232
#[\SensitiveParameter] private string $apiKey,
33-
#[\SensitiveParameter] private string $collection,
33+
private string $collection,
3434
private string $vectorFieldName = '_vectors',
3535
private int $embeddingsDimension = 1536,
3636
) {

0 commit comments

Comments
 (0)