[#52] Adding a test and fixing a few small bugs with the new aliases

Author: weaverryan

src/AppBundle/Subscriber/AutoLabelPRFromContentSubscriber.php

@@ -14,6 +14,14 @@ class AutoLabelPRFromContentSubscriber implements EventSubscriberInterface
 {
     private $labelsApi;
 
+    private static $labelAliases = [
+        'di' => 'DependencyInjection',
+        'bridge\twig' => 'TwigBridge',
+        'router' => 'Routing',
+        'translation' => 'Translator',
+        'twig bridge' => 'TwigBridge',
+    ];
+
     public function __construct(CachedLabelsApi $labelsApi)
     {
         $this->labelsApi = $labelsApi;
@@ -95,7 +103,7 @@ private function extractLabels($prTitle)
      */
     private function getValidLabels()
     {
-        return array(
+        $realLabels = array(
             'Asset', 'BC Break', 'BrowserKit', 'Bug', 'Cache', 'ClassLoader',
             'Config', 'Console', 'Critical', 'CssSelector', 'Debug', 'DebugBundle',
             'DependencyInjection', 'Deprecation', 'Doctrine', 'DoctrineBridge',
@@ -109,6 +117,12 @@ private function getValidLabels()
             'Unconfirmed', 'Validator', 'VarDumper', 'WebProfilerBundle', 'Workflow',
             'Yaml',
         );
+
+        return array_merge(
+            $realLabels,
+            // also consider the "aliases" as valid, so they are used
+            array_keys(self::$labelAliases)
+        );
     }
 
     /**
@@ -117,15 +131,9 @@ private function getValidLabels()
      */
     private function fixLabelName($label)
     {
-        $labelAliases = array(
-            'di' => 'DependencyInjection',
-            'bridge\twig' => 'TwigBridge',
-            'router' => 'Routing',
-            'translation' => 'Translator',
-            'twig bridge' => 'TwigBridge',
-        );
+        $labelAliases = self::$labelAliases;
 
-        if (in_array(strtolower($label), $labelAliases)) {
+        if (isset($labelAliases[strtolower($label)])) {
             return $labelAliases[strtolower($label)];
         }
 

src/AppBundle/Tests/Subscriber/AutoLabelPRFromContentSubscriberTest.php

@@ -150,6 +150,15 @@ public function getPRTests()
             ['Asset', 'BC Break', 'Bug'],
         ];
 
+        // testing the fixLabelName: di -> DependencyInjection
+        $tests[] = [
+            '[di][Fake] Extracting from title [Bug]',
+            <<<EOF
+EOF
+            ,
+            ['DependencyInjection', 'Bug'],
+        ];
+
         return $tests;
     }
 }