bug #122 Make sure to fetch all the labels from Github (Nyholm)

This PR was squashed before being merged into the master branch.

Discussion
----------

Make sure to fetch all the labels from Github

Wohoo. I found a bug.

When we asked Github for all the labels on symfony/symfony, we just got the 20 first ones. This PR will fix that.

Commits
-------

1e9b6d7 Make sure to fetch all the labels from Github

Author: weaverryan

config/packages/github_api.yaml

@@ -5,6 +5,9 @@ services:
         calls:
             - ['authenticate', ['%env(GITHUB_TOKEN)%', 'access_token_header']]
 
+    Github\ResultPager:
+        arguments: ['@Github\Client']
+
     Github\HttpClient\Builder:
         arguments:
             - '@github.httplug_client'

config/services.yaml

@@ -75,6 +75,8 @@ services:
 
     Github\Api\Issue\Labels:
         factory: ['@Github\Api\Issue', labels]
+        calls:
+            - ['setPerPage', [100]]
 
     Github\Api\Issue\Milestones:
         factory: ['@Github\Api\Issue', milestones]

src/Api/Label/GithubLabelApi.php

@@ -5,6 +5,7 @@
 use App\Model\Repository;
 use Github\Api\Issue\Labels;
 use Github\Exception\RuntimeException;
+use Github\ResultPager;
 use Psr\Log\LoggerInterface;
 use Symfony\Contracts\Cache\CacheInterface;
 use Symfony\Contracts\Cache\ItemInterface;
@@ -14,17 +15,22 @@
  */
 class GithubLabelApi implements LabelApi
 {
+    /**
+     * In memory cache for specific issues.
+     *
+     * @var array<array-key, array<array-key, bool>>
+     */
+    private $labelCache = [];
+
     /**
      * @var Labels
      */
     private $labelsApi;
 
     /**
-     * In memory cache for specific issues.
-     *
-     * @var array<array-key, array<array-key, bool>>
+     * @var ResultPager
      */
-    private $labelCache = [];
+    private $resultPager;
 
     /**
      * @var CacheInterface
@@ -36,9 +42,10 @@ class GithubLabelApi implements LabelApi
      */
     private $logger;
 
-    public function __construct(Labels $labelsApi, CacheInterface $cache, LoggerInterface $logger)
+    public function __construct(Labels $labelsApi, ResultPager $resultPager, CacheInterface $cache, LoggerInterface $logger)
     {
         $this->labelsApi = $labelsApi;
+        $this->resultPager = $resultPager;
         $this->cache = $cache;
         $this->logger = $logger;
     }
@@ -118,14 +125,9 @@ public function addIssueLabels($issueNumber, array $labels, Repository $reposito
      */
     public function getAllLabelsForRepository(Repository $repository): array
     {
-        $key = 'labels'.sha1($repository->getFullName());
+        $allLabels = $this->getAllLabels($repository);
 
-        return $this->cache->get($key, function (ItemInterface $item) use ($repository) {
-            $labels = $this->labelsApi->all($repository->getVendor(), $repository->getName()) ?? [];
-            $item->expiresAfter(36000);
-
-            return array_column($labels, 'name');
-        });
+        return array_column($allLabels, 'name');
     }
 
     /**
@@ -136,8 +138,8 @@ public function getComponentLabelsForRepository(Repository $repository): array
         $key = 'component_labels_'.sha1($repository->getFullName());
 
         return $this->cache->get($key, function (ItemInterface $item) use ($repository) {
-            $labels = $this->labelsApi->all($repository->getVendor(), $repository->getName()) ?? [];
-            $item->expiresAfter(36000);
+            $labels = $this->getAllLabels($repository);
+            $item->expiresAfter(86400);
             $componentLabels = [];
             foreach ($labels as $label) {
                 if ('dddddd' === strtolower($label['color'])) {
@@ -149,6 +151,18 @@ public function getComponentLabelsForRepository(Repository $repository): array
         });
     }
 
+    private function getAllLabels(Repository $repository): array
+    {
+        $key = 'labels_'.sha1($repository->getFullName());
+
+        return $this->cache->get($key, function (ItemInterface $item) use ($repository) {
+            $labels = $this->resultPager->fetchAll($this->labelsApi, 'all', [$repository->getVendor(), $repository->getName()]) ?? [];
+            $item->expiresAfter(604800);
+
+            return $labels;
+        });
+    }
+
     private function getCacheKey($issueNumber, Repository $repository)
     {
         return sprintf('%s_%s_%s', $issueNumber, $repository->getVendor(), $repository->getName());

tests/Api/Label/GithubLabelApiTest.php

@@ -5,6 +5,7 @@
 use App\Api\Label\GithubLabelApi;
 use App\Model\Repository;
 use Github\Api\Issue\Labels;
+use Github\ResultPager;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\NullLogger;
@@ -36,7 +37,16 @@ protected function setUp()
         $this->backendApi = $this->getMockBuilder(Labels::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->api = new GithubLabelApi($this->backendApi, new NullAdapter(), new NullLogger());
+
+        $resultPager = $this->getMockBuilder(ResultPager::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['fetchAll'])
+            ->getMock();
+        $resultPager->method('fetchAll')->willReturnCallback(function () {
+            return $this->backendApi->all('x', 'y');
+        });
+
+        $this->api = new GithubLabelApi($this->backendApi, $resultPager, new NullAdapter(), new NullLogger());
         $this->repository = new Repository(
             self::USER_NAME,
             self::REPO_NAME,

tests/Service/LabelNameExtractorTest.php

@@ -14,7 +14,7 @@ public function testExtractLabels()
     {
         $api = new StaticLabelApi();
         $extractor = new LabelNameExtractor($api, new NullLogger());
-        $repo = new Repository('carson-playground', 'symfony');
+        $repo = new Repository('carsonbot-playground', 'symfony');
 
         $this->assertSame(['Messenger'], $extractor->extractLabels('[Messenger] Foobar', $repo));
         $this->assertSame(['Messenger'], $extractor->extractLabels('[messenger] Foobar', $repo));