sharing a function, renaming it, and also checking review permission in

more places

Author: weaverryan

src/AppBundle/Subscriber/AbstractStatusChangeSubscriber.php

@@ -44,7 +44,7 @@ protected function parseStatusFromText($body)
         }
     }
 
-    private function checkUserIsAllowedToReview(array $data)
+    protected function isUserAllowedToReview(array $data)
     {
         return $data['issue']['user']['login'] !== $data['comment']['user']['login'];
     }

src/AppBundle/Subscriber/StatusChangeByCommentSubscriber.php

@@ -31,7 +31,7 @@ public function onIssueComment(GitHubEvent $event)
         $issueNumber = $data['issue']['number'];
         $newStatus = $this->parseStatusFromText($data['comment']['body']);
 
-        if (Status::REVIEWED === $newStatus && false === $this->checkUserIsAllowedToReview($data)) {
+        if (Status::REVIEWED === $newStatus && false === $this->isUserAllowedToReview($data)) {
             $newStatus = null;
         }
 
@@ -54,9 +54,4 @@ public static function getSubscribedEvents()
             GitHubEvents::ISSUE_COMMENT => 'onIssueComment',
         );
     }
-
-    private function checkUserIsAllowedToReview(array $data)
-    {
-        return $data['issue']['user']['login'] !== $data['comment']['user']['login'];
-    }
 }

src/AppBundle/Subscriber/StatusChangeByReviewSubscriber.php

@@ -54,10 +54,10 @@ public function onReview(GitHubEvent $event)
                 break;
             default:
                 $newStatus = $this->parseStatusFromText($data['review']['body']);
+        }
 
-                if (Status::REVIEWED === $newStatus && false === $this->checkUserIsAllowedToReview($data)) {
-                    $newStatus = null;
-                }
+        if (Status::REVIEWED === $newStatus && false === $this->isUserAllowedToReview($data)) {
+            $newStatus = null;
         }
 
         $event->setResponseData(array(
@@ -107,9 +107,4 @@ public static function getSubscribedEvents()
             GitHubEvents::PULL_REQUEST => 'onReviewRequested',
         );
     }
-
-    private function checkUserIsAllowedToReview(array $data)
-    {
-        return $data['pull_request']['user']['login'] !== $data['review']['user']['login'];
-    }
 }