fixed tests

Author: Nyholm

src/Command/CloseStaleIssuesCommand.php

@@ -56,10 +56,10 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         foreach ($issues as $issue) {
             $comment = $this->commentGenerator->getComment($this->extractType($issue));
-            //$this->issueApi->commentOnIssue($repository, $issue['number'], $comment);
+            $this->issueApi->commentOnIssue($repository, $issue['number'], $comment);
 
             // add a scheduled task to process this issue again after 2 weeks
-            //$this->scheduler->runLater($repository, $issue['number'], Task::ACTION_CLOSE_STALE, new \DateTimeImmutable('+2weeks'));
+            $this->scheduler->runLater($repository, $issue['number'], Task::ACTION_CLOSE_STALE, new \DateTimeImmutable('+2weeks'));
         }
 
         return 0;

src/Service/StaleIssueCommentGenerator.php

@@ -14,7 +14,7 @@ class StaleIssueCommentGenerator
     /**
      * Get a comment to say: "I'm closing this now".
      */
-    public function getClosingComment()
+    public function getClosingComment(): string
     {
         return <<<TXT
 Hey,
@@ -36,7 +36,7 @@ public function getComment(string $type): string
             case IssueType::FEATURE:
             case IssueType::RFC:
                 return $this->feature();
-            case IssueType::UNKNOWN:
+            default:
                 return $this->unknown();
         }
     }

tests/Service/TaskHandler/CloseStaleIssuesHandlerTest.php

@@ -8,6 +8,7 @@
 use App\Api\Label\NullLabelApi;
 use App\Entity\Task;
 use App\Service\RepositoryProvider;
+use App\Service\StaleIssueCommentGenerator;
 use App\Service\TaskHandler\CloseStaleIssuesHandler;
 use PHPUnit\Framework\TestCase;
 
@@ -30,7 +31,7 @@ public function testHandleKeepOpen()
 
         $repoProvider = new RepositoryProvider(['carsonbot-playground/symfony' => []]);
 
-        $handler = new CloseStaleIssuesHandler($labelApi, $issueApi, $repoProvider);
+        $handler = new CloseStaleIssuesHandler($labelApi, $issueApi, $repoProvider, new StaleIssueCommentGenerator());
         $handler->handle(new Task('carsonbot-playground/symfony', 4711, Task::ACTION_CLOSE_STALE, new \DateTimeImmutable()));
     }
 
@@ -51,7 +52,7 @@ public function testHandleComments()
 
         $repoProvider = new RepositoryProvider(['carsonbot-playground/symfony' => []]);
 
-        $handler = new CloseStaleIssuesHandler($labelApi, $issueApi, $repoProvider);
+        $handler = new CloseStaleIssuesHandler($labelApi, $issueApi, $repoProvider, new StaleIssueCommentGenerator());
         $handler->handle(new Task('carsonbot-playground/symfony', 4711, Task::ACTION_CLOSE_STALE, new \DateTimeImmutable()));
     }
 
@@ -72,7 +73,7 @@ public function testHandleStale()
 
         $repoProvider = new RepositoryProvider(['carsonbot-playground/symfony' => []]);
 
-        $handler = new CloseStaleIssuesHandler($labelApi, $issueApi, $repoProvider);
+        $handler = new CloseStaleIssuesHandler($labelApi, $issueApi, $repoProvider, new StaleIssueCommentGenerator());
         $handler->handle(new Task('carsonbot-playground/symfony', 4711, Task::ACTION_CLOSE_STALE, new \DateTimeImmutable()));
     }
 }