Removing maintainers, private words thing for now

Just reducing the scope of changes to get a faster merge

Author: weaverryan

app/config/github.yml

@@ -11,24 +11,7 @@ parameters:
         symfony/symfony:
             subscribers:
                 - app.subscriber.issue_subscriber
-            maintainers:
-                - fabpot
-                - webmozart
-                - Tobion
-                - romainneutron
-                - nicolas-grekas
-                - stof
-                - dunglas
-                - aitboudad
-                - jakzal
-                - xabbuh
-                - javiereguiluz
             secret: change_me
         symfony/symfony-docs:
             subscribers:
                 - app.subscriber.issue_subscriber
-            maintainers:
-                - weaverryan
-                - WouterJ
-                - xabbuh
-                - javiereguiluz

src/AppBundle/Event/GitHubEvent.php

@@ -16,13 +16,11 @@ class GitHubEvent extends Event
 
     private $data;
     private $repository;
-    private $maintainers;
 
-    public function __construct(array $data, Repository $repository, array $maintainers = array())
+    public function __construct(array $data, Repository $repository)
     {
         $this->data = $data;
         $this->repository = $repository;
-        $this->maintainers = $maintainers;
     }
 
     public function getData()
@@ -38,11 +36,6 @@ public function getRepository()
         return $this->repository;
     }
 
-    public function getMaintainers()
-    {
-        return $this->maintainers;
-    }
-
     public function getResponseData()
     {
         return $this->responseData;

src/AppBundle/Issues/IssueListener.php

@@ -17,16 +17,12 @@ class IssueListener implements EventSubscriberInterface
         'needs comments' => Status::NEEDS_COMMENTS,
     ];
 
-    private static $privateTriggerWordToStatus = [
-        'ready' => Status::READY,
-    ];
-
     /**
      * @var StatusApi
      */
     private $statusApi;
 
-    final public function __construct(StatusApi $statusApi)
+    public function __construct(StatusApi $statusApi)
     {
         $this->statusApi = $statusApi;
     }
@@ -43,22 +39,16 @@ public function onIssueComment(GitHubEvent $event)
         $repository = $event->getRepository();
         $newStatus = null;
         $issueNumber = $data['issue']['number'];
-        $user = $data['comment']['user']['login'];
-        $statuses = static::$triggerWordToStatus;
-
-        if (in_array($user, $event->getMaintainers(), true)) {
-            $statuses += static::$privateTriggerWordToStatus;
-        }
 
-        $triggerWord = implode('|', array_keys($statuses));
+        $triggerWord = implode('|', array_keys(static::$triggerWordToStatus));
         $formatting = '[\\s\\*]*';
         // Match first character after "status:"
         // Case insensitive ("i"), ignores formatting with "*" before or after the ":"
         $pattern = "~(?=\n|^)${formatting}status${formatting}:${formatting}[\"']?($triggerWord)[\"']?${formatting}[.!]?${formatting}(?<=\r\n|\n|$)~i";
 
         if (preg_match_all($pattern, $data['comment']['body'], $matches)) {
             // Second subpattern = first status character
-            $newStatus = $statuses[strtolower(end($matches[1]))];
+            $newStatus = static::$triggerWordToStatus[strtolower(end($matches[1]))];
 
             $this->setIssueStatus($issueNumber, $newStatus, $repository);
         }
@@ -79,20 +69,20 @@ public function onPullRequest(GitHubEvent $event)
         $data = $event->getData();
         $repository = $event->getRepository();
         if ('opened' !== $action = $data['action']) {
-            $responseData = array('unsupported_action' => $action);
-        } else {
-            $pullRequestNumber = $data['pull_request']['number'];
-            $newStatus = Status::NEEDS_REVIEW;
-
-            $this->setIssueStatus($pullRequestNumber, $newStatus, $repository);
+            $event->setResponseData(array('unsupported_action' => $action));
 
-            $responseData = array(
-                'pull_request' => $pullRequestNumber,
-                'status_change' => $newStatus,
-            );
+            return;
         }
 
-        $event->setResponseData($responseData);
+        $pullRequestNumber = $data['pull_request']['number'];
+        $newStatus = Status::NEEDS_REVIEW;
+
+        $this->setIssueStatus($pullRequestNumber, $newStatus, $repository);
+
+        $event->setResponseData(array(
+            'pull_request' => $pullRequestNumber,
+            'status_change' => $newStatus,
+        ));
     }
 
     /**

src/AppBundle/Repository/Repository.php

@@ -75,10 +75,4 @@ public function getSecret()
     {
         // todo - implement setting a secret
     }
-
-    public function getMaintainers()
-    {
-        // todo - implement this
-        return [];
-    }
 }