bug #123 Don't mark PRs with "WIP" as "ready for review" (Nyholm)

This PR was squashed before being merged into the master branch.

Discussion
----------

Don't mark PRs with "WIP" as "ready for review"

Commits
-------

450f7b9 Don't mark PRs with "WIP" as "ready for review"

Author: weaverryan

src/Repository/.gitignore

@@ -0,0 +1,17 @@
+<?php
+
+namespace App\Service;
+
+/**
+ * @author Tobias Nyholm <tobias.nyholm@gmail.com>
+ */
+class WipParser
+{
+    /**
+     * Returns true if the title begins by [WIP], (WIP) or WIP:.
+     */
+    public static function matchTitle(string $title): bool
+    {
+        return (bool) preg_match('@^(\[wip\]|\(wip\)|wip:)@mi', $title);
+    }
+}

src/Service/WipParser.php

@@ -6,6 +6,7 @@
 use App\Api\Status\StatusApi;
 use App\Event\GitHubEvent;
 use App\GitHubEvents;
+use App\Service\WipParser;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 
 class NeedsReviewNewPRSubscriber implements EventSubscriberInterface
@@ -28,6 +29,10 @@ public function onPullRequest(GitHubEvent $event)
             return;
         }
 
+        if (WipParser::matchTitle($data['pull_request']['title'])) {
+            return;
+        }
+
         $pullRequestNumber = $data['pull_request']['number'];
         $newStatus = Status::NEEDS_REVIEW;
 

src/Subscriber/NeedsReviewNewPRSubscriber.php

@@ -6,6 +6,7 @@
 use App\Api\Status\StatusApi;
 use App\Event\GitHubEvent;
 use App\GitHubEvents;
+use App\Service\WipParser;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 
 /**
@@ -36,7 +37,7 @@ public function onPullRequest(GitHubEvent $event)
         $currentStatus = $this->statusApi->getIssueStatus($pullRequestNumber, $repository);
         $pullRequestTitle = $data['pull_request']['title'];
 
-        if (Status::NEEDS_WORK !== $currentStatus || false !== stripos($pullRequestTitle, '[wip]')) {
+        if (Status::NEEDS_WORK !== $currentStatus || WipParser::matchTitle($pullRequestTitle)) {
             $responseData['status_change'] = null;
             $event->setResponseData($responseData);
 

src/Subscriber/StatusChangeOnPushSubscriber.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Service;
+
+use App\Service\WipParser;
+use PHPUnit\Framework\TestCase;
+
+class WipParserTest extends TestCase
+{
+    public function testMatchTitle()
+    {
+        $this->assertTrue(WipParser::matchTitle('[WIP] foo'));
+        $this->assertTrue(WipParser::matchTitle('WIP: bar'));
+        $this->assertTrue(WipParser::matchTitle('(WIP) xas'));
+        $this->assertTrue(WipParser::matchTitle('[WIP]foo'));
+        $this->assertTrue(WipParser::matchTitle('[wip] foo'));
+
+        $this->assertFalse(WipParser::matchTitle('Bar [WIP] foo'));
+        $this->assertFalse(WipParser::matchTitle('FOOWIP: foo'));
+    }
+}

tests/Service/WipParserTest.php

@@ -42,7 +42,7 @@ public function testOnPullRequestOpen()
 
         $event = new GitHubEvent([
             'action' => 'opened',
-            'pull_request' => ['number' => 1234],
+            'pull_request' => ['number' => 1234, 'title' => 'foobar'],
         ], $this->repository);
 
         $this->dispatcher->dispatch($event, GitHubEvents::PULL_REQUEST);
@@ -54,6 +54,23 @@ public function testOnPullRequestOpen()
         $this->assertSame(Status::NEEDS_REVIEW, $responseData['status_change']);
     }
 
+    public function testOnPullRequestOpenWIP()
+    {
+        $this->statusApi->expects($this->never())
+            ->method('setIssueStatus')
+            ->with(1234, Status::NEEDS_REVIEW);
+
+        $event = new GitHubEvent([
+            'action' => 'opened',
+            'pull_request' => ['number' => 1234, 'title' => '[WIP] foobar'],
+        ], $this->repository);
+
+        $this->dispatcher->dispatch($event, GitHubEvents::PULL_REQUEST);
+
+        $responseData = $event->getResponseData();
+        $this->assertEmpty($responseData);
+    }
+
     public function testOnPullRequestNotOpen()
     {
         $this->statusApi->expects($this->never())