SymEngine::Integer to int implicit conversion

Author: rajithv

ext/symengine/ruby_integer.c

@@ -6,3 +6,4 @@ VALUE cinteger_init(VALUE self, VALUE num_value) {
     GET_SYMINTFROMVAL(num_value, this);
     return self;
 }
+

ext/symengine/ruby_ntheory.c

@@ -12,8 +12,8 @@ VALUE cntheory_lcm(VALUE self, VALUE operand1, VALUE operand2) {
     return function_twoarg(ntheory_lcm, operand1, operand2);
 }
 
-VALUE cntheory_mod(VALUE self, VALUE operand1, VALUE operand2) {
-    VALUE ans = function_twoarg(ntheory_mod, operand1, operand2);
+VALUE cntheory_mod(VALUE self, VALUE operand2) {
+    VALUE ans = function_twoarg(ntheory_mod, self, operand2);
     VALUE ans1 = cbasic_add(ans, operand2);
     return function_twoarg(ntheory_mod, ans1, operand2);
 }

ext/symengine/ruby_ntheory.h

@@ -11,7 +11,7 @@
 VALUE cntheory_gcd(VALUE self, VALUE operand1, VALUE operand2);
 VALUE cntheory_lcm(VALUE self, VALUE operand1, VALUE operand2);
 VALUE cntheory_nextprime(VALUE self, VALUE operand1);
-VALUE cntheory_mod(VALUE self, VALUE operand1, VALUE operand2);
+VALUE cntheory_mod(VALUE self, VALUE operand2);
 VALUE cntheory_quotient(VALUE self, VALUE operand1, VALUE operand2);
 VALUE cntheory_fibonacci(VALUE self, VALUE operand1);
 VALUE cntheory_lucas(VALUE self, VALUE operand1);

ext/symengine/symengine.c

@@ -53,6 +53,7 @@ void Init_symengine() {
     c_integer = rb_define_class_under(m_symengine, "Integer", c_basic);
     rb_define_alloc_func(c_integer, cbasic_alloc);
     rb_define_method(c_integer, "initialize", cinteger_init, 1);
+    rb_define_method(c_integer, "%", cntheory_mod, 1);
 
     //Rational class
     c_rational = rb_define_class_under(m_symengine, "Rational", c_basic);
@@ -150,7 +151,6 @@ void Init_symengine() {
     rb_define_module_function(m_symengine, "gcd", cntheory_gcd, 2);
     rb_define_module_function(m_symengine, "lcm", cntheory_lcm, 2);
     rb_define_module_function(m_symengine, "nextprime", cntheory_nextprime, 1);
-    rb_define_module_function(m_symengine, "%", cntheory_mod, 2);
     rb_define_module_function(m_symengine, "quotient", cntheory_quotient, 2);
     rb_define_module_function(m_symengine, "fibonacci", cntheory_fibonacci, 1);
     rb_define_module_function(m_symengine, "lucas", cntheory_lucas, 1);

lib/symengine.rb

@@ -34,3 +34,4 @@ def symbols ary_or_string, *params
 require 'symengine/symengine'
 require 'symengine/iruby'
 require 'symengine/basic'
+require 'symengine/integer'

lib/symengine/integer.rb

@@ -0,0 +1,7 @@
+module SymEngine
+  class Integer
+    def to_int
+        self.to_s.to_i
+    end
+  end
+end

spec/ntheory_spec.rb

@@ -1,10 +1,18 @@
 require 'spec_helper'
 
 describe SymEngine do
+
   before :each do
   end
 
   describe 'NTheory' do
+    before :each do
+      @i1 = SymEngine::Integer.new(1)
+      @i4 = SymEngine::Integer.new(4)
+      @i5 = SymEngine::Integer.new(5)
+      @im4 = SymEngine::Integer.new(-4)
+      @im5 = SymEngine::Integer.new(-5)
+    end
 
     describe '#gcd' do
       context 'GCD of 2 and 4' do
@@ -36,25 +44,25 @@
     describe '#mod' do
       context '5 mod 4' do
         it 'returns 1' do
-          f = 5 % 4
+          f = @i5 % @i4
           expect(f).to eql(1)
         end
       end
       context '-5 mod -4' do
         it 'returns -1' do
-          f = -5 % -4
+          f = @im5 % @im4
           expect(f).to eql(-1)
         end
       end
       context '5 mod -4' do
         it 'returns -3' do
-          f = 5 % -4
+          f = @i5 % @im4
           expect(f).to eql(-3)
         end
       end
       context '-5 mod 4' do
         it 'returns 3' do
-          f = -5 % 4
+          f = @im5 % @i4
           expect(f).to eql(3)
         end
       end
@@ -76,12 +84,24 @@
           expect(f).to eql(5)
         end
       end
+      context '5th Fibonacci Number' do
+        it 'returns 5' do
+          f = SymEngine::fibonacci(@i5)
+          expect(f).to eql(5)
+        end
+      end
     end
 
     describe '#lucas' do
       context '1st Lucas Number' do
         it 'returns 1' do
-          f = SymEngine::fibonacci(1)
+          f = SymEngine::lucas(1)
+          expect(f).to eql(1)
+        end
+      end
+      context '1st Lucas Number' do
+        it 'returns 1' do
+          f = SymEngine::lucas(@i1)
           expect(f).to eql(1)
         end
       end
@@ -94,6 +114,12 @@
           expect(f).to eql(5)
         end
       end
+      context 'binomial (n=5, k=1)' do
+        it 'returns 5' do
+          f = SymEngine::binomial(@i5, @i1)
+          expect(f).to eql(5)
+        end
+      end
     end
 
   end